Skip to content

[5.1] Dark Mode final Version#42986

Merged
LadySolveig merged 306 commits intojoomla:5.1-devfrom
coolcat-creations:dark-mode-5.1-dev-final
Mar 11, 2024
Merged

[5.1] Dark Mode final Version#42986
LadySolveig merged 306 commits intojoomla:5.1-devfrom
coolcat-creations:dark-mode-5.1-dev-final

Conversation

@coolcat-creations
Copy link
Copy Markdown
Contributor

@coolcat-creations coolcat-creations commented Mar 9, 2024

This is a follow up of #42757 and #42010 for Joomla 5.1

Summary of Changes

Dark mode modifications and improvements

Testing Instructions

Turn on dark mode in your browser or O/S

Actual result BEFORE applying this Pull Request

old dark mode

Expected result AFTER applying this Pull Request

improved dark mode

MacJoom and others added 30 commits October 9, 2023 23:28
CS - thanks for the suggestions

Co-authored-by: Brian Teeman <brian@teeman.net>
…s.scss

Co-authored-by: Brian Teeman <brian@teeman.net>
…s.scss

Co-authored-by: Brian Teeman <brian@teeman.net>
…s.scss

Co-authored-by: Brian Teeman <brian@teeman.net>
…s.scss

Co-authored-by: Brian Teeman <brian@teeman.net>
…s.scss

Co-authored-by: Brian Teeman <brian@teeman.net>
…s.scss

Co-authored-by: Brian Teeman <brian@teeman.net>
…s-dark.scss

Co-authored-by: Brian Teeman <brian@teeman.net>
…s.scss

Co-authored-by: Brian Teeman <brian@teeman.net>
@Quy
Copy link
Copy Markdown
Contributor

Quy commented Mar 10, 2024

#42506

Install the plugin.
Go to Extensions.
Find switch.
Click a button under Version.

pkg_switcheditor_2-2.2.4.zip

@brianteeman
Copy link
Copy Markdown
Contributor

image

image

@coolcat-creations
Copy link
Copy Markdown
Contributor Author

LTR

image

RTL

image

Same issue repeated in dark mode

fixed for darkmode, lightmode needs to go into separate PR

@LadySolveig LadySolveig merged commit 985b174 into joomla:5.1-dev Mar 11, 2024
@LadySolveig
Copy link
Copy Markdown
Contributor

Thank you very much for the great work and your commitment @coolcat-creations and @MacJoom ! 💟 🚀
Many thanks also to all those who participated in testing and provided feedback - great to see this wonderful collaboration.

@Kostelano
Copy link
Copy Markdown
Contributor

System --> Guided Tours, when hovering the cursor

Screenshot_1

@coolcat-creations
Copy link
Copy Markdown
Contributor Author

@Kostelano thank you for the finding. As this is merged, can you please open a new issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants