[5.1] Update Jooa11y with latest Sa11y build (Attempt #2) by adamchaboryk · Pull Request #42780 · joomla/joomla-cms

adamchaboryk · 2024-02-09T15:26:55Z

Continuation of #42768 based on @Fedik's review and feedback. Includes updated screenshots of changes.

(Sorry for re-creating the PR. Had issues re-basing from 5.0 to 5.1. After I renamed the branch on my fork, I inadvertently closed my PR.)

Summary of Changes

This PR adds Sa11y as a dependency, ensuring seamless and automatic updates for future Joomla releases.

Sa11y is added as a dependency via build/build-modules-js/settings.json.
Addition of several new languages.
- New languages would be added by modifying build/build-modules-js/settings.json.
- Automatic language detection based on page language.
- Note: Only the admin settings will utilize Joomla's PLG language system.
New configuration/properties in admin settings to customize experience for content editors.

Related issue: joomla-projects/joomla-a11y-checker#75

Testing Instructions

Ensure you have a fresh JS build via npm install
Navigate to "Accessibility Check" as you would normally. Accessibility Checker should appear in same spot.
Add a language pack (like German for example), and ensure Accessibility Checker displays correct translation.

Actual result BEFORE applying this Pull Request

https://joomla-projects.github.io/joomla-a11y-checker/pages/errors.html

Expected result AFTER applying this Pull Request

Accessibility Check preview

Plugin settings with descriptions

Includes a couple of Extra Props for demonstration purposes. Extra props can accept boolean/numeric/string based on Sa11y's documentation.

Link to documentations

Please select:

Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: I'll do a PR later to update this page https://manual.joomla.org/docs/accessibility/testing
No documentation changes for manual.joomla.org needed

Work in progress

Account for empty values

Work in progress

Account for empty values

…into 5.0-dev

Fedik · 2024-02-09T17:28:58Z

Thanks!
Only thing is left is to fix code style :)
https://ci.joomla.org/joomla/joomla-cms/73378/1/7
It looks like you mixed something with an indents

administrator/language/en-GB/plg_system_jooa11y.ini

Co-authored-by: Quy <quy@nomonkeybiz.com>

administrator/language/en-GB/plg_system_jooa11y.ini

Co-authored-by: Brian Teeman <brian@teeman.net>

And now I'm done embarrassing myself!

adamchaboryk · 2024-02-13T15:22:08Z

Enabling this option will visually hide the toggle switches for Form Labels, Contrast, Links (Advanced) in the Settings panel.

Works for me, makes more sense.

brianteeman · 2024-02-13T15:42:10Z

A release lead needs to decide if it is ok to delete all these unused strings r if we must follow previous policy that they should be deprecated instead

Fedik · 2024-02-14T13:25:50Z

@adamchaboryk I made another PR for string deprecation adamchaboryk#3
Unfortunatley we cannot just delete them

Deprecate strings

administrator/language/en-GB/plg_system_jooa11y.ini

administrator/language/en-GB/plg_system_jooa11y.sys.ini

Co-authored-by: Brian Teeman <brian@teeman.net>

plugins/system/jooa11y/src/Extension/Jooa11y.php

brianteeman · 2024-02-14T21:09:47Z

will give it a more detailed test tomottow but it looks good to me

brianteeman · 2024-02-15T21:40:05Z

I have tested this item ✅ successfully on 9144751

Thanks Adam

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42780.}

Fedik · 2024-02-16T07:44:41Z

r2c

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42780.}

LadySolveig · 2024-02-20T09:22:35Z

Added the language strings deprecation also to to the migration section in the documentation

joomla/Manual#223

brianteeman · 2024-02-20T09:26:44Z

great -= thanks all

LadySolveig · 2024-02-20T09:31:39Z

Thank you so much @adamchaboryk for your work and for taking care on the implementation into Joomla and this very nice new features 🚀
I really enjoyed seeing this great collaboration - thanks to everyone for being involved @Fedik @brianteeman @Quy @dgrammatiko

adamchaboryk · 2024-02-20T14:42:50Z

Thank you, Martina! I'm super excited for 5.1! I'm also very grateful for all the support and guidance from everyone. Looking forward to future collaborations!

joomla/joomla-cms#42780 +

adamchaboryk added 15 commits January 16, 2024 23:18

Updating Jooa11y with latest build of Sa11y - WIP

e3279bc

Work in progress

Update Jooa11y (Work in Progress)

49cdd39

Merge branch 'joomla:5.0-dev' into 5.0-dev

bfbe3d7

Merge branch 'joomla:5.0-dev' into 5.0-dev

4750711

Allow users to pass in boolean props to jooa11y

e1104d2

Update Jooa11y.php

9a0b950

Account for empty values

UMD to ESM

7fd9040

Fixes based on @Fedik's feedback!

6674a90

Updating Jooa11y with latest build of Sa11y - WIP

59e9c2b

Work in progress

Update Jooa11y (Work in Progress)

96ed0d1

Allow users to pass in boolean props to jooa11y

462c442

Update Jooa11y.php

818b12e

Account for empty values

UMD to ESM

c53af66

Fixes based on @Fedik's feedback!

0325e07

Merge branch '5.0-dev' of https://github.com/adamchaboryk/joomla-cms …

bf2d4f4

…into 5.0-dev

joomla-cms-bot added Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev labels Feb 9, 2024

Fedik added the Feature label Feb 9, 2024

Quy reviewed Feb 9, 2024

View reviewed changes

administrator/language/en-GB/plg_system_jooa11y.ini Outdated Show resolved Hide resolved

Update administrator/language/en-GB/plg_system_jooa11y.ini

1b19647

Co-authored-by: Quy <quy@nomonkeybiz.com>

brianteeman reviewed Feb 9, 2024

View reviewed changes

administrator/language/en-GB/plg_system_jooa11y.ini Outdated Show resolved Hide resolved

adamchaboryk and others added 7 commits February 9, 2024 13:42

Update administrator/language/en-GB/plg_system_jooa11y.ini

e42fada

Co-authored-by: Brian Teeman <brian@teeman.net>

Fix code style/indents

798f6b6

Take 2: Make linter happy

b044f96

Attempt #3 - Make linter happy

ed9a310

Attempt 4 at making linter happy

ddb39f3

Last attempt at making linter happy

52bc85f

Okay, actual last attempt at making linter happy

6ded6e2

And now I'm done embarrassing myself!

Update plg_system_jooa11y.ini

a9f1927

Deprecate strings

912f945

Merge pull request #3 from Fedik/pull42780

df26b1d

Deprecate strings

brianteeman reviewed Feb 14, 2024

View reviewed changes

administrator/language/en-GB/plg_system_jooa11y.ini Outdated Show resolved Hide resolved

brianteeman reviewed Feb 14, 2024

View reviewed changes

administrator/language/en-GB/plg_system_jooa11y.ini Outdated Show resolved Hide resolved

brianteeman reviewed Feb 14, 2024

View reviewed changes

administrator/language/en-GB/plg_system_jooa11y.sys.ini Outdated Show resolved Hide resolved

adamchaboryk and others added 3 commits February 14, 2024 16:03

Update administrator/language/en-GB/plg_system_jooa11y.ini

0d569ca

Co-authored-by: Brian Teeman <brian@teeman.net>

Update administrator/language/en-GB/plg_system_jooa11y.ini

390c360

Co-authored-by: Brian Teeman <brian@teeman.net>

Update administrator/language/en-GB/plg_system_jooa11y.sys.ini

f9ebd52

Co-authored-by: Brian Teeman <brian@teeman.net>

brianteeman reviewed Feb 14, 2024

View reviewed changes

plugins/system/jooa11y/src/Extension/Jooa11y.php Show resolved Hide resolved

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 16, 2024

Merge branch '5.1-dev' into 5.1-dev

070c8f3

LadySolveig merged commit 8cc6616 into joomla:5.1-dev Feb 20, 2024

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 20, 2024

LadySolveig added this to the Joomla! 5.1.0 milestone Feb 20, 2024

jgerman-bot mentioned this pull request Feb 21, 2024

[5.1] Update Jooa11y with latest Sa11y build (Attempt #2) joomlagerman/joomla#3095

Closed

Kostelano added a commit to JPathRu/localisation that referenced this pull request Feb 24, 2024

Плагин "Система - Проверка доступности"

9a928a1

joomla/joomla-cms#42780 +

richard67 mentioned this pull request Mar 1, 2024

[5.1] Update deleted files list in script.php for 5.1.0-beta1 #42935

Merged

2 tasks

brianteeman mentioned this pull request Mar 4, 2024

[5.1] remove joomla accessibility checker #42949

Merged

brianteeman mentioned this pull request Dec 22, 2025

[6.1] tinymce and sa11y updates #46600

Merged

4 tasks

Uh oh!

Conversation

adamchaboryk commented Feb 9, 2024

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Accessibility Check preview

Plugin settings with descriptions

Link to documentations

Uh oh!

Fedik commented Feb 9, 2024

Uh oh!

Uh oh!

Uh oh!

adamchaboryk commented Feb 13, 2024

Uh oh!

brianteeman commented Feb 13, 2024

Uh oh!

Fedik commented Feb 14, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

brianteeman commented Feb 14, 2024

Uh oh!

brianteeman commented Feb 15, 2024

Uh oh!

Fedik commented Feb 16, 2024

Uh oh!

LadySolveig commented Feb 20, 2024

Uh oh!

brianteeman commented Feb 20, 2024

Uh oh!

LadySolveig commented Feb 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adamchaboryk commented Feb 20, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

LadySolveig commented Feb 20, 2024 •

edited

Loading