Thanks for this work @adamchaboryk

To those that don't know Adam is the creator of sa11y. We originally made a hard fork for the reasons stated here joomla-projects/joomla-a11y-checker#75 but it is not really needed now.

The only major consideration for the Production Dept and maintainers is that the language strings are now provided by sa11y and not by Joomla. But thats no different to how the tinymce translations are done now. (this will probably necessitate an update/uninstall script.)

Thanks for this work @adamchaboryk

To those that don't know Adam is the creator of sa11y. We originally made a hard fork for the reasons stated here joomla-projects/joomla-a11y-checker#75 but it is not really needed now.

The only major consideration for the Production Dept and maintainers is that the language strings are now provided by sa11y and not by Joomla. But thats no different to how the tinymce translations are done now. (this will probably necessitate an update/uninstall script.)

Thanks @brianteeman! I'm looking forward to future contributions — I'll ensure new translations make its way into Joomla!

Hi Adam, thanks for the PR .
I will give a couple notes, later 😉

Is this page (https://manual.joomla.org/docs/accessibility/testing) something I can help update?

The manual lives here https://github.com/joomla/Manual
If you like, you can do PR to edit it.

In Joomla we do not mix PHP with JavaScript code, it is forbiden 😉
It require a couple changes in the PR.

Since Joomla 5 we can use ESM importmap, basicaly it is a WebAsset with special property https://manual.joomla.org/docs/general-concepts/web-asset-manager#working-with-esm-importmap

I have wrote a couple notes, I hope I did not forget anything :)

Another thing looks strange is extraProps, I kind of understand why you made it.
In wich format user should enter this value?

If you want just a key/value, you can use a subform field instead of textarea:

<field type="subform" name="extraProps" multiple="true" label="foobar label">
 <form>
  <field type="text" name="key" label="Key"/>
  <field type="text" name="value" label="Value"/>
 </form>
</field>

If just a key/bool, then:

<field type="subform" name="extraProps" multiple="true" label="foobar label">
 <form>
  <field type="text" name="key" label="Key"/>
  <field type="radio" name="value" label="Value" default="1" layout="joomla.form.field.radio.switcher">
   <option value="0">JOFF</option>
   <option value="1">JON</option>
  </field>
 </form>
</field>

Then you do not need that complex function prepareExtraProps($extraProps) in plugin.

One more thing, please rebase it to 5.1-dev branch, because 5.0-dev only for bugfixes already.

Thank you for the detailed feedback, @Fedik! I attempted (my first) re-base, and I don't think it went very smoothly... My apologies — I did not mean to send out multiple review requests.