[5.1] Use Dialog for Batch windows#42328
Merged
LadySolveig merged 12 commits intojoomla:5.1-devfrom Nov 16, 2023
Merged
Conversation
dgrammatiko
reviewed
Nov 10, 2023
build/media_source/com_fields/js/admin-fields-default-batch.es6.js
Outdated
Show resolved
Hide resolved
…6.js Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
Contributor
|
I have tested this item ✅ successfully on 6b7061f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42328. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 6b7061f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42328. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42328. |
Contributor
|
Thank you for your work @Fedik ! |
4 tasks
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Nov 18, 2023
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Use Dialog for Batch windows
The same as #40359 but for rest of Batch buttons.
Testing Instructions
Run
npm installTest Batch dialog for:
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works
Link to documentations
Please select:
References: