Skip to content

[5.0] Joomla Dialog for Aricles, Categories batch and Finder Index with Statistic#40359

Merged
HLeithner merged 17 commits intojoomla:5.0-devfrom
Fedik:popup-batch
Sep 5, 2023
Merged

[5.0] Joomla Dialog for Aricles, Categories batch and Finder Index with Statistic#40359
HLeithner merged 17 commits intojoomla:5.0-devfrom
Fedik:popup-batch

Conversation

@Fedik
Copy link
Copy Markdown
Member

@Fedik Fedik commented Apr 10, 2023 •
edited
Loading

Summary of Changes

An implementation of Joomla Dialog for for Aricles, Categories batch and Finder Index with Statistic.
Depends from #40150

It works but not fully finished.
It still will be need some stilyng for batch modals and solution for 'onclose' 🥔

joomla-cms/administrator/components/com_finder/src/View/Index/HtmlView.php

Line 183 in 0659dc2

->onclose('window.parent.location.reload()')

Testing Instructions

Apply patch then apply #40150, run npm install.
Check Article, Categories batch, and Finder Index wtih Statistic popups. Versions popup

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org: [5.0] Toolbar popup button Manual#184
  • No documentation changes for manual.joomla.org needed

@Fedik Fedik marked this pull request as draft April 10, 2023 14:06
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.0-dev labels Apr 10, 2023
@Fedik Fedik mentioned this pull request Apr 10, 2023
Merged
2 tasks
@dgrammatiko
Copy link
Copy Markdown
Contributor

dgrammatiko commented Apr 10, 2023

and solution for onclose

That needs to be killed, it's not CSP strict and by default it's an XSS vulnerability as users could execute any arbitrary code using that event. In sort all the inline events should be considered harmful and removed ASAP...

@Fedik
Copy link
Copy Markdown
Member Author

Fedik commented Apr 10, 2023

That needs to be killed, it's not CSP strict ...

I am fine with removing.
I have fixed it for Finder, however it still may be an issue for extensions.

@dgrammatiko
Copy link
Copy Markdown
Contributor

dgrammatiko commented Apr 10, 2023

however it still may be an issue for extensions.

If Joomla is serious about security, those vectors should be removed. My 2c

@Fedik Fedik added the Feature label Apr 11, 2023
@Fedik Fedik changed the title Joomla Dialog for Aricles batch and Finder Index with Statistic Joomla Dialog for Aricles, Categories batch and Finder Index with Statistic Apr 12, 2023
@Fedik Fedik changed the title Joomla Dialog for Aricles, Categories batch and Finder Index with Statistic [5.0] Joomla Dialog for Aricles, Categories batch and Finder Index with Statistic Apr 23, 2023
Fedik added 4 commits June 10, 2023 18:30
@Fedik
Sync. Merge branch '5.0-dev' into popup-batch
de41aed 
 Conflicts:
	administrator/components/com_finder/src/View/Index/HtmlView.php
@Fedik
Merge branch '5.0-dev' into popup-batch
f7de03b 
 Conflicts:
	build/media_source/com_content/joomla.asset.json
@Fedik
fix asset name
5f391cf
@Fedik
fix asset name
c2558c3
@Fedik Fedik marked this pull request as ready for review August 21, 2023 13:19
@HLeithner
Copy link
Copy Markdown
Member

HLeithner commented Aug 22, 2023

i think the b/c plugin still has a reference to this es5?

@Fedik
Copy link
Copy Markdown
Member Author

Fedik commented Aug 22, 2023

hmhm, what to reference?

@HLeithner
Copy link
Copy Markdown
Member

HLeithner commented Aug 22, 2023

hmm I think I comment on the wrong PR

@HLeithner HLeithner merged commit b0064dc into joomla:5.0-dev Sep 5, 2023
@HLeithner
Copy link
Copy Markdown
Member

HLeithner commented Sep 5, 2023

thanks, documentation update please

@HLeithner HLeithner added this to the Joomla! 5.0 milestone Sep 5, 2023
@Fedik Fedik deleted the popup-batch branch September 5, 2023 07:37
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 5, 2023
@richard67
Add deleted files from PR joomla#40359
64c3b1d
@richard67 richard67 mentioned this pull request Sep 5, 2023
Merged
4 tasks
HLeithner pushed a commit that referenced this pull request Sep 5, 2023
@richard67
[5.0] Update deleted files list in script.php for 5.0.0-beta1 (2) (#4…
c2328dc 
…1598)

* Add deleted files from PR #40359

* Remove duplicate entry
@Fedik Fedik mentioned this pull request Sep 5, 2023
Merged
@Fedik
Copy link
Copy Markdown
Member Author

Fedik commented Sep 5, 2023

There it is joomla/Manual#184

@Quy Quy mentioned this pull request Sep 20, 2023
Closed
@Fedik Fedik mentioned this pull request Sep 20, 2023
Merged
4 tasks
@Fedik Fedik mentioned this pull request Nov 9, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Quy Quy Quy left review comments

Assignees

No one assigned

Labels

Documentation Required Feature NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Milestone

Joomla! 5.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Fedik @dgrammatiko @HLeithner @Quy @joomla-cms-bot