Skip to content

[5.0] Move the compatibility plugin from system to behaviour folder#41276

Merged
HLeithner merged 3 commits intojoomla:5.0-devfrom
HLeithner:5.0/feature/move-bc-plugin
Aug 1, 2023
Merged

[5.0] Move the compatibility plugin from system to behaviour folder#41276
HLeithner merged 3 commits intojoomla:5.0-devfrom
HLeithner:5.0/feature/move-bc-plugin

Conversation

@HLeithner
Copy link
Copy Markdown
Member

This allows system plugins using the JPlugin class to still work with joomla 5.0 compatibility enabled

Pull Request for Issue when system plugins need JPlugin before the b/c plugin is loaded

Summary of Changes

Moved the plugin from the system folder to the behaviour folder which is the first folder loaded by the cms.

Testing Instructions

Use a system plugin which extends JPlugin.

Actual result BEFORE applying this Pull Request

Might not work

Expected result AFTER applying this Pull Request

Works now.

This allows system plugins using the JPlugin class to still work with joomla 5.0 compatibility enabled
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.0-dev labels Jul 29, 2023
@brianteeman
Copy link
Copy Markdown
Contributor

Please add scripts to remove the system plugin files
Please add sql to remove the system plugin
Please update the language strings to use the correct prefix

@HLeithner
Copy link
Copy Markdown
Member Author

not planing to do so, within alpha, only starting with beta1 to include an upgrade path

@brianteeman
Copy link
Copy Markdown
Contributor

This is wrong - makes the nightly builds pointless

@HLeithner
Copy link
Copy Markdown
Member Author

not true, they are for new installations and update from last stable version.

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Jul 29, 2023

not true but you clearly know best and are free to change the practices of the last few years. Perhaps you could point me to the place on the downbload page for nightly builds where it states that. From my reading of that document there is no mention of your assertion.

@HLeithner
Copy link
Copy Markdown
Member Author

Warning! These builds are intended for testing purposes only and should never be used on production websites.

We can break joomla installations beyond repair and in alpha version till beta1 of joomla 4 no upgrade policy exists. before this point in time even update breaks between rc and final exists (can't remember if this happend or not).

any way alpha is for testing and not for wasting time to write update scripts for 10 users that might need them because they don't have backups.

@bayareajenn
Copy link
Copy Markdown

I have tested this item ✅ successfully on 71c7f5f

This resolved the issue for extensions with class JPlugin not working with the b/c plugin enabled. Tested two extensions that previously wouldn't install with b/c plugin enabled without throwing the JPlugin error. They install with this PR. Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41276.

@HLeithner HLeithner merged commit 1031c9d into joomla:5.0-dev Aug 1, 2023
@HLeithner HLeithner deleted the 5.0/feature/move-bc-plugin branch August 1, 2023 18:55
@HLeithner
Copy link
Copy Markdown
Member Author

thanks for testing

richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 12, 2023
- Deleted files and folders from PR joomla#41276
- Renamed file from PR joomla#41260
GeraintEdwards pushed a commit to GeraintEdwards/joomla-cms that referenced this pull request Aug 14, 2023
…oomla#41276)

* Move the compatibility plugin from system to behaviour folder

This allows system plugins using the JPlugin class to still work with joomla 5.0 compatibility enabled

* Fix Language string

* Fix SQL update scripts for compat plugin
GeraintEdwards pushed a commit to GeraintEdwards/joomla-cms that referenced this pull request Aug 14, 2023
…oomla#41276)

* Move the compatibility plugin from system to behaviour folder

This allows system plugins using the JPlugin class to still work with joomla 5.0 compatibility enabled

* Fix Language string

* Fix SQL update scripts for compat plugin
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 19, 2023
- Deleted files and folders from PR joomla#41276
- Renamed file from PR joomla#41260
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 19, 2023
These files and folders will be removed by the uninstallation of the plugin.
HLeithner pushed a commit that referenced this pull request Aug 20, 2023
* Add deleted files and folders and renamed files

- Deleted files and folders from PR #41276
- Renamed file from PR #41260

* Migrate enabled and params from old system plugin on update

* Remove deleted files and folders from PR #41276

These files and folders will be removed by the uninstallation of the plugin.

* Add exceptions to deleted file check script

These files and folders will be removed by the uninstallation of the plugin and therefore should not be added to the lists of deleted files and folders.

* Add deleted files and folders from PR #41289

* Add /media/plg_system_compat to exceptions

* Remove /media/plg_system_compat deleted files and folders

* Revert "Remove /media/plg_system_compat deleted files and folders"

This reverts commit ea429a6.

* Revert "Add /media/plg_system_compat to exceptions"

This reverts commit 296febf.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants