Skip to content

[5.0] schema.org cleanup#41260

Merged
HLeithner merged 12 commits intojoomla:5.0-devfrom
bembelimen:5.0/schema-org-cleanup
Aug 5, 2023
Merged

[5.0] schema.org cleanup#41260
HLeithner merged 12 commits intojoomla:5.0-devfrom
bembelimen:5.0/schema-org-cleanup

Conversation

@bembelimen
Copy link
Copy Markdown
Contributor

@bembelimen bembelimen commented Jul 26, 2023

Summary of Changes

  • Moved cleanup functions to individual traits
  • Added traits to each plugin
  • Improved blog/categories views
  • Added global cleanup to schemaorg system plugin

Testing Instructions

  • Create different articles with schema information
  • Check head area of your page

Actual result BEFORE applying this Pull Request

  • empty values
  • wrong format for date/image/durations

Expected result AFTER applying this Pull Request

  • No empty values
  • Correct image/date/duration compilation

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

brianteeman
brianteeman reviewed Jul 27, 2023
View reviewed changes
brianteeman
brianteeman reviewed Jul 27, 2023
View reviewed changes
brianteeman
brianteeman reviewed Jul 27, 2023
View reviewed changes
brianteeman
brianteeman reviewed Jul 27, 2023
View reviewed changes
brianteeman
brianteeman reviewed Jul 27, 2023
View reviewed changes
brianteeman
brianteeman reviewed Jul 27, 2023
View reviewed changes
@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Jul 27, 2023 •
edited
Loading

I am getting this in the frontendand admin for all the schema
example

Deprecated
: Calling static trait method Joomla\CMS\Schemaorg\SchemaorgPluginTrait::getSubscribedEvents is deprecated, it should only be called on a class using the trait in plugins\schemaorg\blogposting\src\Extension\Blogposting.php
on line
61

Php 8.1.10

@brianteeman brianteeman mentioned this pull request Jul 27, 2023
Closed
heelc29
heelc29 reviewed Jul 27, 2023
View reviewed changes
bembelimen and others added 3 commits July 27, 2023 19:40
@bembelimen
Fix deprecation and file name
908b72f
@bembelimen
Fix deprecations
7d69541
@bembelimen @heelc29 @brianteeman
Apply suggestions from code review
6ec9d21 
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
Co-authored-by: Brian Teeman <brian@teeman.net>
bembelimen
bembelimen commented Jul 27, 2023
View reviewed changes
@bembelimen
Copy link
Copy Markdown
Contributor Author

bembelimen commented Jul 27, 2023

I am getting this in the frontendand admin for all the schema example

Deprecated
: Calling static trait method Joomla\CMS\Schemaorg\SchemaorgPluginTrait::getSubscribedEvents is deprecated, it should only be called on a class using the trait in plugins\schemaorg\blogposting\src\Extension\Blogposting.php
on line
61

Php 8.1.10

Thx,
tried here something which did not work anymore. Fixed it now.

@HLeithner HLeithner mentioned this pull request Jul 27, 2023
Closed
@laoneo
Copy link
Copy Markdown
Member

laoneo commented Jul 28, 2023

What is the benefit of having here traits and not a proper base class as we have for actionlog, fields, etc.?

@HLeithner
Copy link
Copy Markdown
Member

HLeithner commented Jul 28, 2023

What is the benefit of having here traits and not a proper base class as we have for actionlog, fields, etc.?

you only take the traits you need.

heelc29
heelc29 reviewed Jul 29, 2023
View reviewed changes
heelc29
heelc29 reviewed Jul 29, 2023
View reviewed changes
heelc29
heelc29 reviewed Jul 29, 2023
View reviewed changes
bembelimen and others added 4 commits August 5, 2023 02:38
@Fedik
Copy link
Copy Markdown
Member

Fedik commented Aug 5, 2023

I have tested this item ✅ successfully on 7d87e4d

It is working from what I can see :)

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41260.

@HLeithner HLeithner merged commit fe2074e into joomla:5.0-dev Aug 5, 2023
@HLeithner
Copy link
Copy Markdown
Member

HLeithner commented Aug 5, 2023

Thanks

@LadySolveig LadySolveig mentioned this pull request Aug 5, 2023
Merged
2 tasks
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 12, 2023
@richard67
Add deleted files and folders and renamed files
2e4016c 
- Deleted files and folders from PR joomla#41276
- Renamed file from PR joomla#41260
GeraintEdwards pushed a commit to GeraintEdwards/joomla-cms that referenced this pull request Aug 14, 2023
@bembelimen @heelc29
@brianteeman @Geraint2
[5.0] schema.org cleanup (joomla#41260)
568bdf5 
* Add json cleanup

* CS fix

* Fix deprecation and file name

* Fix deprecations

* Apply suggestions from code review

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
Co-authored-by: Brian Teeman <brian@teeman.net>

* Update libraries/src/Schemaorg/SchemaorgPrepareDurationTrait.php

* Update libraries/src/Schemaorg/SchemaorgPrepareDurationTrait.php

* Apply suggestions from code review

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

* Fix namespace

* Activate cache by default

---------

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
Co-authored-by: Brian Teeman <brian@teeman.net>
GeraintEdwards pushed a commit to GeraintEdwards/joomla-cms that referenced this pull request Aug 14, 2023
@bembelimen @heelc29
@brianteeman @Geraint2
[5.0] schema.org cleanup (joomla#41260)
989912e 
* Add json cleanup

* CS fix

* Fix deprecation and file name

* Fix deprecations

* Apply suggestions from code review

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
Co-authored-by: Brian Teeman <brian@teeman.net>

* Update libraries/src/Schemaorg/SchemaorgPrepareDurationTrait.php

* Update libraries/src/Schemaorg/SchemaorgPrepareDurationTrait.php

* Apply suggestions from code review

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

* Fix namespace

* Activate cache by default

---------

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
Co-authored-by: Brian Teeman <brian@teeman.net>
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 19, 2023
@richard67
Add deleted files and folders and renamed files
be5d256 
- Deleted files and folders from PR joomla#41276
- Renamed file from PR joomla#41260
This was referenced Aug 19, 2023
Closed
Merged
@heelc29 heelc29 mentioned this pull request Aug 20, 2023
Closed
HLeithner pushed a commit that referenced this pull request Aug 20, 2023
@richard67
[5.0] [RFC] Fix update path from previous 5.0.0 alphas (#41394)
7b7c6aa 
* Add deleted files and folders and renamed files

- Deleted files and folders from PR #41276
- Renamed file from PR #41260

* Migrate enabled and params from old system plugin on update

* Remove deleted files and folders from PR #41276

These files and folders will be removed by the uninstallation of the plugin.

* Add exceptions to deleted file check script

These files and folders will be removed by the uninstallation of the plugin and therefore should not be added to the lists of deleted files and folders.

* Add deleted files and folders from PR #41289

* Add /media/plg_system_compat to exceptions

* Remove /media/plg_system_compat deleted files and folders

* Revert "Remove /media/plg_system_compat deleted files and folders"

This reverts commit ea429a6.

* Revert "Add /media/plg_system_compat to exceptions"

This reverts commit 296febf.
@brianteeman brianteeman mentioned this pull request Oct 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@brianteeman brianteeman brianteeman left review comments

@heelc29 heelc29 heelc29 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@bembelimen @brianteeman @laoneo @HLeithner @Fedik @heelc29 @joomla-cms-bot