Conversation
|
Language files...? SITE\administrator\language\en-GB\plg_task_demotasks.ini |
|
What if a site is actually using it>? |
administrator/components/com_admin/sql/updates/mysql/5.0.0-2023-03-17.sql
Outdated
Show resolved
Hide resolved
administrator/components/com_admin/sql/updates/postgresql/5.0.0-2023-03-17.sql
Outdated
Show resolved
Hide resolved
We would need to check the sheduler table before i guess. Not sure whether we should actually do that with j4.4 but 5.0 and within j4.4 or 4.3 we alert the users of stuff we intent to remove by 5.0. In practical terms i would say the impact is low but you are right it should be tested too. |
|
The real world problem is that on a site that has enabled any of the demo tasks (to see what they did) simply removing the plugin will leave an orphaned record |
|
Yes said record could be removed too but i personally would say thats something for 5.0 not 4.4. |
|
Agree, the record should deleted as well. |
…0-2023-03-17.sql Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
|
Ah got confused looks like this PR is already against 5.0. ;) |
The problem is that we really should not be removing something from a users site without their knowledge. They might, for example, be using one of those demo tasks as part of their own server monitoring. |
How do you want to use it for monitoring? All this task does is to wait for the defined amount of time. |
|
We need a documentation entry and this plugin in the documentation as example how to create a plugin like this? What would you say to an own repository which can be used as source for automatically installing the plugin within the system tests? |
|
@laoneo can you remove the sql files, so if the plugin exists from an update it still exists but no longer available on new installations? @richard67 please keep this in mind when creating the deleted files array for j5 thanks |
It just needs to add the files to the list of exclusions here so it does not produce false alarms: https://github.com/joomla/joomla-cms/blob/5.0-dev/build/deleted_file_check.php#L63 . Will do so. |
Update: Ah, I see, it needs to remove the update SQL in this PR so the plugin isn't deleted when updating. Update 2: Not sure if it also needs to revert the removal from the ExtensionsHelper here https://github.com/joomla/joomla-cms/pull/40147/files#diff-45688fa5398ae3d4bab3daa80bc4d2ea4785370233b82a7326f9676f965ec9ebL311 so the plugin is still considered a core plugin when it still exists after an update. |
since it's no longer a core extensions I think it should be removed |
Agree. I just checked and we don't have weblinks or search in the extensions helper, which are similar cases. |
I don't think this is a good idea as it is not maintained anymore and when we change something in the scheduler, it can break your site. There is really no need to have a demo plugin in core which can only do a sleep call. |
administrator/components/com_admin/sql/updates/mysql/5.0.0-2023-03-17.sql
Outdated
Show resolved
Hide resolved
administrator/components/com_admin/sql/updates/postgresql/5.0.0-2023-03-17.sql
Outdated
Show resolved
Hide resolved
|
Updated |
|
@laoneo PR for you is Digital-Peak#30 . |
* Use script.php to uninstall the plugin * Use script.php to delete the obsolete tasks * Fix doc block comment * Revert change to script.php for deleting tasks
|
motion for this removal was successful in production, @laoneo can you create a documentation entry on manual (b/c break) |
Here we go joomla/Manual#132 |
Удалено в Joomla 5, joomla/joomla-cms#40147
Delete the demo task plugin. This is not needed anymore as the scheduler has other plugins in core and extension developers have started to create their own ones.