[CMS PR 40147] Use script.php to uninstall the plugin#30
[CMS PR 40147] Use script.php to uninstall the plugin#30laoneo merged 4 commits intoDigital-Peak:task/demo/deletefrom
Conversation
|
Unfortunately the |
|
I think this pr makes not much sense migrating the sql to the migrate function, we use sql to delete extensions content, we should use the migration function only if we really need it for migration. if sql is possible keep it in sql. |
@HLeithner You mean completely not use this PR here? Or only revert this commit e68037d for using script.php to delete the old tasks? |
|
yes I mean the commit which move the removal from the sql file to the script.php |
|
@HLeithner Done. |
|
Thanks @richard67, good work! |
Pull Request for joomla#40147 .
Summary of Changes
Use the new function introduced with joomla#40768 instead of the update SQL script for uninstalling the obsolete plugin and removing its tasks on update.
The update SQL script is still used for removing the task(s).
Testing Instructions
Code review, or update a 4.4-dev nightly build or 5.0.0-alpha1 to a 5.0-dev update package which contains the changes from here and from the CMS PR.