[4.3] Converts editor buttons to service providers#39649
Merged
obuisard merged 4 commits intojoomla:4.3-devfrom Jan 19, 2023
Merged
[4.3] Converts editor buttons to service providers#39649obuisard merged 4 commits intojoomla:4.3-devfrom
obuisard merged 4 commits intojoomla:4.3-devfrom
Conversation
laoneo
reviewed
Jan 16, 2023
Member
|
I'm just wondering if the namespace should be a bit more clear. I know they are inline with the rest, but Xtd doesn't say much. Why not just going with Joomla\Plugin\EditorButton\Article. |
Contributor
Author
|
Let’s keep the Xtd suffix, as I plan to roll a new set with the upcoming modal (dialog element) and @Fedik wants to have couple more events for the editors so the EditorsButtons would be used there |
Member
|
I have tested this item ✅ successfully on 9f0987d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39649. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 9f0987d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39649. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39649. |
Contributor
|
Thank you Dimitris @dgrammatiko :-) |
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jan 21, 2023
Add deleted files from PRs joomla#39379 , joomla#39539 , joomla#39624 , joomla#39649 and joomla#39625 .
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Testing Instructions
administrator/cache/autoload_psr4.phpActual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
@laoneo