Converts tinymce to service providers#39625
Merged
obuisard merged 7 commits intojoomla:4.3-devfrom Jan 15, 2023
Merged
Conversation
Contributor
|
@laoneo thank you for the one! I'll test it in a bit |
dgrammatiko
suggested changes
Jan 13, 2023
Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
Member
Author
|
I'v uploaded a fix, it should work now. Strange thing was that it loaded without that change for me |
Contributor
|
I have tested this item ✅ successfully on 53b65ed This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39625. |
Contributor
|
I have tested this item ✅ successfully on 15e3454 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39625. |
Contributor
|
I have tested this item ✅ successfully on 15e3454 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39625. |
Quy
reviewed
Jan 15, 2023
Member
Author
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39625. |
This was referenced Jan 15, 2023
Contributor
|
Thank you Allon @laoneo! |
4 tasks
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jan 21, 2023
Add deleted files from PRs joomla#39379 , joomla#39539 , joomla#39624 , joomla#39649 and joomla#39625 .
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Converts the tinymce editor to service providers.
Testing Instructions
Also test if the other editors do still work
Actual result BEFORE applying this Pull Request
All works.
Expected result AFTER applying this Pull Request
All works.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed