obvioously there is an issue with drone as this should have been picked up

obvioously there is an issue with drone as this should have been picked up

That it's just a warning, I guess it's ok for drone ...

I have tested this item ✅ successfully on dd0e85e

Warning from eslint is fixed.

I have tested this item ✅ successfully on dd0e85e

RTC

Although this PR cleans up the warning there are more problems in this file, eg the addEventListener('DOMContentLoaded', ...) is an ANTIPATTERN and should be removed (the file is either loaded with attribute defer or type=module which render the waiting for the DOM to be ready useless). I had fixed it correctly with #38225: https://github.com/joomla/joomla-cms/pull/38225/files#diff-4afb4f910136391957e62b8afcb5f0d6b240ee226cd69b4960777bc15ddfe668

The code should be:

/**
 * @copyright  (C) 2022 Open Source Matters, Inc. <https://www.joomla.org>
 * @license    GNU General Public License version 2 or later; see LICENSE.txt
 */
[].slice.call(document.querySelectorAll('.article-status')).forEach((element) => {
  element.addEventListener('click', (event) => {
    event.stopPropagation();
  });
});

or even more compact:

/**
 * @copyright  (C) 2022 Open Source Matters, Inc. <https://www.joomla.org>
 * @license    GNU General Public License version 2 or later; see LICENSE.txt
 */
[].slice.call(document.querySelectorAll('.article-status')).forEach((element) => element.addEventListener('click', (event) => event.stopPropagation()));

@obuisard this might be a good project for 4.3: clean all the addEventListener('DOMContentLoaded', ...) from the javascript files!
The anti pattern is explained here: https://www.youtube.com/watch?v=_iq1fPjeqMQ

I agree @dgrammatiko, this should be cleaned up. Do you mind writing a PR for this issue and if you can't work on it I will try and rally the troops so you get help :-)

@obuisard you could use #35725 as a guide.
In short the scripts need to:

• be converted to type=module + add the -es5 in the dependencies
• remove the iife, if exists (type= module scripts are scoped by default)
• remove strict mode (type= module is strict by default)
• remove the addEventListener('DOMContentLoaded', ...) as it's pure overhead