[4.0] Simplify keepalive.js#35725
Conversation
|
@Stuartemk yes all these are correct... Edit: probably you're totally unaware how Joomla is dealing with the static assets, please read the readme.md: https://github.com/joomla/joomla-cms/tree/4.0-dev/build |
Ok I do not understand why, I admit my lack of knowledge, but since I mentioned that and you confirm that it is well I trust. |
|
Simplifying turns out not to simple 😄 |
|
I have tested this item ✅ successfully on 1652beb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35725. |
| "uri": "system/keepalive-es5.min.js", | ||
| "attributes": { | ||
| "defer": true, | ||
| "nomodule": true |
There was a problem hiding this comment.
I don't fully understand the assets system, why the "nomodule": true here but "type": "module" for non-es5?
There was a problem hiding this comment.
There was a problem hiding this comment.
Thank you! I have much to learn here
|
I have tested this item ✅ successfully on 1652beb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35725. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35725. |
|
Thx |
Pull Request for Issue # .
Summary of Changes
Testing Instructions
Apply the PR
Change the
Session Lifetime (minutes)to1inGlobal Configuration->SystemObserve the Other in the network tab of your browser's console
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
None, We're switching from XHR to sendBeacon which is widely supported
https://caniuse.com/beacon