[4.2] article status script#38154
Merged
roland-d merged 7 commits intojoomla:4.2-devfrom Jun 30, 2022
Merged
Conversation
Completes an `@todo` by moving an inline script to a standaloine script using webassetmanager.
Contributor
|
This pull requests has been automatically converted to the PSR-12 coding standard. |
Contributor
|
I have tested this item ✅ successfully on 7b62221 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38154. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 7b62221 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38154. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38154. |
Contributor
|
Thanks everybody |
brianteeman
added a commit
to brianteeman/joomla-cms
that referenced
this pull request
Jul 12, 2022
* [4.2] article status script Completes an `@todo` by moving an inline script to a standaloine script using webassetmanager. * Phase 1 convert BRANCH to PSR-12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes an
@todoby moving an inline script to a standaloine script using webassetmanager.Testing Instructions
The script is used to disable clicking on the status icon in the content admin when workflows is enabled.
apply the pr and
npm ciExpected result AFTER applying this Pull Request
workflows disabled - no change the status button is clickable
workflows enabled - no change the status button is not clickable
Documentation Changes Required