Skip to content

[4.2] Fix redirect on login url error#38299

Merged
roland-d merged 2 commits intojoomla:4.2-devfrom
joomdonation:fix_login_redirect_url
Aug 1, 2022
Merged

[4.2] Fix redirect on login url error#38299
roland-d merged 2 commits intojoomla:4.2-devfrom
joomdonation:fix_login_redirect_url

Conversation

@joomdonation
Copy link
Copy Markdown
Contributor

Pull Request for Issue #38297.

Summary of Changes

See #38297 to understand the issue

Testing Instructions

  1. Install Joomla 4.2 nightly build
  2. Confirm the issue [4.2] Redirect on login url error #38297
  3. Apply patch, confirm that the issue fixed
  4. If it is possible, test the login redirect on a multilingual website and make sure it is still working as expected.

Actual result BEFORE applying this Pull Request

There is unnecessary lang variable with empty value in login, logout redirect URL

Expected result AFTER applying this Pull Request

No unnecessary lang variable any,ore

Documentation Changes Required

None

@brianteeman
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on e4ac5c3

quick test on a mono-lingual site only


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38299.

@viocassel
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on e4ac5c3

Tested on multilingual site


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38299.

@alikon
Copy link
Copy Markdown
Contributor

alikon commented Jul 19, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38299.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 19, 2022
@roland-d roland-d merged commit c21bfa6 into joomla:4.2-dev Aug 1, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 1, 2022
@roland-d
Copy link
Copy Markdown
Contributor

roland-d commented Aug 1, 2022

Thank you

@roland-d roland-d added this to the Joomla! 4.2.0 milestone Aug 1, 2022
@joomdonation joomdonation deleted the fix_login_redirect_url branch August 1, 2022 08:55
brianteeman pushed a commit to brianteeman/joomla-cms that referenced this pull request Aug 2, 2022
rdeutz pushed a commit to joomla-projects/joomla-cms that referenced this pull request Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants