Fix tinymce when sorting happen#36345
Merged
roland-d merged 12 commits intojoomla:4.2-devfrom Jan 19, 2023
Merged
Conversation
Member
|
This pull request has automatically rebased to 4.2-dev. |
Contributor
|
This pull requests has been automatically converted to the PSR-12 coding standard. |
Conflicts: build/media_source/plg_editors_tinymce/js/plugins/dragdrop/plugin.es5.js
|
I have tested this item ✅ successfully on 1007fe6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36345. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36345. |
Contributor
|
I have tested this item ✅ successfully on 1007fe6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36345. |
Contributor
|
Thank you |
Contributor
|
@Fedik Please check why the editor loses focus when editing an article. |
Member
Author
|
@Quy what wrong with focus? works fine for me |
Contributor
|
It is reloading between
|
Member
Author
|
I see, Firefox and Chrome handle iframe events diferently. I will check. |
2 tasks
fancyFranci
pushed a commit
that referenced
this pull request
Jan 22, 2023
dgrammatiko
added a commit
to dgrammatiko/muta
that referenced
this pull request
Feb 3, 2023
Basically joomla/joomla-cms#36345
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #24343 .
Summary of Changes
The patch re-init an editor when the iframe moved around DOM.
Testing Instructions
Apply patch, run
npm installPlease follow #24343
Or create subform with editor (example in Custom HTML):
Add couple rows in subform and try sort them. Then watch editor content.
Actual result BEFORE applying this Pull Request
Content are gone.
Expected result AFTER applying this Pull Request
Content still there (can be with little delay)
Documentation Changes Required
None