Fix for fix #36345, TinyMCE, make sure iframe is fully loaded#39686
Merged
fancyFranci merged 2 commits intojoomla:4.2-devfrom Jan 22, 2023
Merged
Fix for fix #36345, TinyMCE, make sure iframe is fully loaded#39686fancyFranci merged 2 commits intojoomla:4.2-devfrom
fancyFranci merged 2 commits intojoomla:4.2-devfrom
Conversation
Member
Author
|
@Quy please test |
Contributor
|
I have tested this item ✅ successfully on d4de355 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39686. |
Member
|
I have tested this item ✅ successfully on d4de355 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39686. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39686. |
Contributor
|
Thank you for fixing the fix :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #36345 for fix #24343
Summary of Changes
Make sure the script listen iframe load event only once.
Testing Instructions
Apply patch, run
npm installCreate subform with editor (example in Custom HTML):
Run test in Chrome and Firefox, and Safari (if you have one).
Make sure the Article content editor works correctly.
Then add couple rows in subform and try sort them. Then watch editor content.
Actual result BEFORE applying this Pull Request
In Firefox the Article content editor realods itself, and not able to edit content.
Expected result AFTER applying this Pull Request
In all Browsers the content editor works correctly.
Content in subform editor works after sorting.
Link to documentations
Please select: