Skip to content

[4.0] ] fix color selector box too big issue#33611

Merged
richard67 merged 1 commit intojoomla:4.0-devfrom
brianteeman:minicolor
May 7, 2021
Merged

[4.0] ] fix color selector box too big issue#33611
richard67 merged 1 commit intojoomla:4.0-devfrom
brianteeman:minicolor

Conversation

@brianteeman
Copy link
Copy Markdown
Contributor

I am not 100% convinced this is the correct solution but based on the accepted code in #30585 it is a working solution

npm run build:css

Pull Request for Issue #33596

After applying PR etc
image

I am not 100% convinced this is the correct solution but based on the accepted code in joomla#30585 it is a working solution

npm run build:css
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels May 6, 2021
@Quy
Copy link
Copy Markdown
Contributor

Quy commented May 6, 2021

I have tested this item ✅ successfully on faf4287


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33611.

2 similar comments
@Shubham-com
Copy link
Copy Markdown

I have tested this item ✅ successfully on faf4287


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33611.

@Kostelano
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on faf4287


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33611.

@joomla-cms-bot joomla-cms-bot removed NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels May 7, 2021
@alikon
Copy link
Copy Markdown
Contributor

alikon commented May 7, 2021

RTC

3 is a perfect number for me 😄


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33611.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 7, 2021
@richard67 richard67 added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels May 7, 2021
@richard67 richard67 added this to the Joomla 4.0 milestone May 7, 2021
@richard67 richard67 merged commit 2865c95 into joomla:4.0-dev May 7, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 7, 2021
@richard67
Copy link
Copy Markdown
Member

Thanks!

@brianteeman
Copy link
Copy Markdown
Contributor Author

thanks - still not 100% this is the best way

@brianteeman brianteeman deleted the minicolor branch May 7, 2021 13:07
@richard67
Copy link
Copy Markdown
Member

But a bit better than before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants