Skip to content

[4.0] fix color selector box too small issue#30585

Merged
laoneo merged 2 commits intojoomla:4.0-devfrom
pdkpavankumar:color-selector-box
Sep 8, 2020
Merged

[4.0] fix color selector box too small issue#30585
laoneo merged 2 commits intojoomla:4.0-devfrom
pdkpavankumar:color-selector-box

Conversation

@pdkpavankumar
Copy link
Copy Markdown
Contributor

@pdkpavankumar pdkpavankumar commented Sep 7, 2020

Pull Request for Issue #29954 .
#29954

Summary of Changes

Increased the height of the color box to match input box

Testing Instructions

safari on Mac

Edit atum template style in Joomla admin
Colour Settings tab

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Documentation Changes Required

No

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Sep 7, 2020
@Quy Quy mentioned this pull request Sep 7, 2020
Closed
@Quy
Copy link
Copy Markdown
Contributor

Quy commented Sep 7, 2020

I have tested this item ✅ successfully on 200704e

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30585.

@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Sep 7, 2020

I have tested this item ✅ successfully on 200704e

Ok on Safari, Firefox, Chrome

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30585.

@infograf768 infograf768 removed NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Sep 7, 2020
@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Sep 7, 2020

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30585.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 7, 2020
@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Sep 7, 2020

Restarted drone

@Quy Quy added the PR-4.0-dev label Sep 7, 2020
@richard67
Copy link
Copy Markdown
Member

richard67 commented Sep 7, 2020

@pdkpavankumar Our scss code style checker fails with errors, see https://ci.joomla.org/joomla/joomla-cms/35279/1/22 for the details. Could you check and fix that? If you need help with that, let us know here. Thanks in advance.

@joomla-cms-bot joomla-cms-bot added the NPM Resource Changed This Pull Request can't be tested by Patchtester label Sep 7, 2020
@pdkpavankumar
Copy link
Copy Markdown
Contributor Author

pdkpavankumar commented Sep 7, 2020

@richard67 i have fixed the sass stylelint error

@richard67
Copy link
Copy Markdown
Member

richard67 commented Sep 7, 2020

@pdkpavankumar Thanks for the quick fix. By the way, if you want to check results of such tests like code style or system tests yourself, you can find a section with these tests at the bottom of each pull request. If all tests were successful this section is hidden but can be expanded with a link "Show all checks". Then right beside each check is a link "Details", which leads then to the log of the test.

@infograf768 infograf768 removed the NPM Resource Changed This Pull Request can't be tested by Patchtester label Sep 7, 2020
@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Sep 7, 2020

Reset to pending as there was a change

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30585.

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 7, 2020
@infograf768 infograf768 added the NPM Resource Changed This Pull Request can't be tested by Patchtester label Sep 7, 2020
@richard67
Copy link
Copy Markdown
Member

richard67 commented Sep 7, 2020

@pdkpavankumar And by the way: Thank you very much for your first pull request (PR) for the Joomla CMS.

@Quy
Copy link
Copy Markdown
Contributor

Quy commented Sep 7, 2020

I have tested this item ✅ successfully on f6f3de2

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30585.

@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Sep 7, 2020

I have tested this item ✅ successfully on f6f3de2

Lesson: never set RTC when drone is still working or fails, even if it looks unrelated to the PR.. ;)

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30585.

@infograf768 infograf768 added RTC This Pull Request is Ready To Commit and removed NPM Resource Changed This Pull Request can't be tested by Patchtester labels Sep 7, 2020
@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Sep 7, 2020

RTC now for good. Hopefully.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30585.

@laoneo laoneo merged commit ad5895d into joomla:4.0-dev Sep 8, 2020
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester and removed RTC This Pull Request is Ready To Commit labels Sep 8, 2020
@laoneo
Copy link
Copy Markdown
Member

laoneo commented Sep 8, 2020

Nice one, thanks!

@laoneo laoneo added this to the Joomla 4.0 milestone Sep 8, 2020
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
@pdkpavankumar @sakiss
[4.0] fix color selector box too small issue (joomla#30585)
c4c9c0c 
* [4.0] fix color selector box too small issue

* removed redundant & for fixing sass lint error
brianteeman added a commit to brianteeman/joomla-cms that referenced this pull request May 6, 2021
@brianteeman
[4.0] ] fix color selector box too big issue
faf4287 
I am not 100% convinced this is the correct solution but based on the accepted code in joomla#30585 it is a working solution

npm run build:css
@brianteeman brianteeman mentioned this pull request May 6, 2021
Merged
richard67 pushed a commit that referenced this pull request May 7, 2021
@brianteeman
[4.0] ] fix color selector box too big issue (#33611)
2865c95 
I am not 100% convinced this is the correct solution but based on the accepted code in #30585 it is a working solution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Milestone

Joomla 4.0

Development

Successfully merging this pull request may close these issues.

6 participants

@pdkpavankumar @Quy @infograf768 @richard67 @laoneo @joomla-cms-bot