[4.0] Site Contacts Category List Search Filters by infograf768 · Pull Request #30813 · joomla/joomla-cms

infograf768 · 2020-09-30T10:56:52Z

Summary of Changes

Adding Search Filter and Clear buttons to the List Contacts in a Category menu item.
Modify the placeholder string to specify the search is limited to the Contact Title.

Testing Instructions

Create multiple contacts in the same category.
Create a List Contacts in a Category menu item for this category.
Make sure Filter Field is set to Show in the menu parameters.
Display the menu item in frontend.

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Note

With a similar PR, we can add a Clear filter button in the List Articles in a Category menu item
It would be nice to add css for the Clear button in order to display a different color when the filter field is empty and not. I guess this would be for the Cassiopea Team to deal with.

brianteeman · 2020-10-01T09:48:57Z

Thanks for that last change to use sr-only - I was about to comment and got distracted

brianteeman · 2020-10-01T09:49:25Z

I have tested this item ✅ successfully on 9da66d3

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30813.}

infograf768 · 2020-10-01T10:24:16Z

Note:
1.

Thanks for that last change to use sr-only - I was about to comment and got distracted

We will need to do the same for articles list. Will modify that in the new PR if this PR is accepted and merged.

We have to be able to modify the number of items displayed in the list by using the limit box.
It is impossible right now because the code forces $limit value to the parameters set in contact Options and the menu item, contrary to articles.
I have a patch for that. Will propose later.

jwaisner · 2020-10-01T16:41:25Z

I have tested this item ✅ successfully on 9da66d3

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30813.}

jwaisner · 2020-10-01T16:41:43Z

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30813.}

wilsonge · 2020-10-02T01:30:27Z

Thanks!

* [4.0] Missing js file in #30813 * missing new line

…s-cs * '4.0-dev' of github.com:joomla/joomla-cms: [4.0] Templates: Styles (Administrator) menu color changes on save (joomla#30847) Namespace (joomla#30865) [4.0] Fall back to system template when template file not found (joomla#30857) [4.0] joomla update show password (joomla#30849) [4.0] com_media options (joomla#30852) [4.0] Update lib_joomla.ini (joomla#30867) [4.0] Missing js file in joomla#30813 (joomla#30859) [4.0] Site Contacts Category List Search Filters (joomla#30813) Add update SQL script for previous 4.0 beta versions Dont use id in WHERE clause for updating menu items in update SQL script

infograf768 · 2020-10-03T09:33:26Z

Concerning the list limit issue, please test #30904

…ue-cs * '4.0-dev' of github.com:joomla/joomla-cms: (22 commits) [4.0] Change the size of the template name font in module position selector (joomla#30890) [4.0] Media Manager close preview (joomla#30851) [4.0] sticky sidebar menu (joomla#30853) [4.0] treeselect alerts (joomla#30854) [4.0] Fix pagebreak modal missing style (joomla#30889) [4.0] xtd-editor button for module (joomla#30892) [4.0] Templates: Styles (Administrator) menu color changes on save (joomla#30847) Namespace (joomla#30865) [4.0] Fall back to system template when template file not found (joomla#30857) [4.0] joomla update show password (joomla#30849) [4.0] com_media options (joomla#30852) [4.0] Update lib_joomla.ini (joomla#30867) [4.0] Missing js file in joomla#30813 (joomla#30859) [4.0] Site Contacts Category List Search Filters (joomla#30813) [4.0] Article Links markup (joomla#30824) [4.0] Language reinstall (joomla#30810) [4.0] tinmyce toolbar icons (joomla#30825) [4.0] hidden-xs-up (joomla#30837) Update com_mails.ini (joomla#30842) [4.0] Add css style for mod_articles_news vertical layout (joomla#30797) ... # Conflicts: # administrator/components/com_media/resources/scripts/components/modals/modal.vue

* [4.0] Missing js file in joomla#30813 * missing new line

PR for #33021 Hopefully this resolves the bug reported with #30813. #30904 tried to fix it by removing the feature introduced with #23710 completely which was wrong Co-authored-by: Tuan Pham Ngoc <github@joomdonation.com>

[4.0] Site Contacts Category List Filters

a768cc6

joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Sep 30, 2020

infograf768 mentioned this pull request Oct 1, 2020

Remove *.* selector from _forms.scss joomla/cassiopeia#151

Merged

Adding fieldset legend

ba8ed3b

joomla-cms-bot added the Language Change This is for Translators label Oct 1, 2020

a11y

9da66d3

infograf768 mentioned this pull request Oct 1, 2020

[4.0] hidden-xs-up #30837

Merged

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 1, 2020

wilsonge merged commit 2110e63 into joomla:4.0-dev Oct 2, 2020

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 2, 2020

wilsonge added this to the Joomla 4.0 milestone Oct 2, 2020

infograf768 added a commit to infograf768/joomla-cms that referenced this pull request Oct 2, 2020

[4.0] Missing js file in joomla#30813

6120ebb

infograf768 mentioned this pull request Oct 2, 2020

[4.0] Missing js file in #30813 #30859

Merged

HLeithner pushed a commit that referenced this pull request Oct 2, 2020

[4.0] Missing js file in #30813 (#30859)

ce55812

* [4.0] Missing js file in #30813 * missing new line

infograf768 deleted the 4.0_sitecontactlistfiltering branch October 2, 2020 07:10

infograf768 mentioned this pull request Oct 2, 2020

[4.0] Normalise Featured Contact List #30868

Merged

jgerman-bot mentioned this pull request Oct 2, 2020

[4.0] Site Contacts Category List Search Filters joomlagerman/joomla#1264

Closed

infograf768 mentioned this pull request Oct 3, 2020

[4.0] Frontend: Fix List Contacts Category List Limit #30904

Merged

sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020

[4.0] Site Contacts Category List Search Filters (joomla#30813)

4470852

sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020

[4.0] Missing js file in joomla#30813 (joomla#30859)

250622d

* [4.0] Missing js file in joomla#30813 * missing new line

brianteeman mentioned this pull request Apr 7, 2021

[4.0] Contact Category list limits #33050

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[4.0] Site Contacts Category List Search Filters#30813

[4.0] Site Contacts Category List Search Filters#30813
wilsonge merged 3 commits intojoomla:4.0-devfrom
infograf768:4.0_sitecontactlistfiltering

infograf768 commented Sep 30, 2020

Uh oh!

brianteeman commented Oct 1, 2020

Uh oh!

brianteeman commented Oct 1, 2020

Uh oh!

infograf768 commented Oct 1, 2020

Uh oh!

jwaisner commented Oct 1, 2020

Uh oh!

jwaisner commented Oct 1, 2020

Uh oh!

wilsonge commented Oct 2, 2020

Uh oh!

infograf768 commented Oct 3, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

infograf768 commented Sep 30, 2020

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Note

Uh oh!

brianteeman commented Oct 1, 2020

Uh oh!

brianteeman commented Oct 1, 2020

Uh oh!

infograf768 commented Oct 1, 2020

Uh oh!

jwaisner commented Oct 1, 2020

Uh oh!

jwaisner commented Oct 1, 2020

Uh oh!

wilsonge commented Oct 2, 2020

Uh oh!

infograf768 commented Oct 3, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants