Skip to content

[4.0] New configs to display featured contacts at the top & number of contacts to display on a contact list page#23710

Merged
wilsonge merged 19 commits intojoomla:4.0-devfrom
vaibhavsTekdi:featurecontactsconfig-4.0
Apr 11, 2019
Merged

[4.0] New configs to display featured contacts at the top & number of contacts to display on a contact list page#23710
wilsonge merged 19 commits intojoomla:4.0-devfrom
vaibhavsTekdi:featurecontactsconfig-4.0

Conversation

@vaibhavsTekdi
Copy link
Copy Markdown
Contributor

@vaibhavsTekdi vaibhavsTekdi commented Jan 29, 2019 •
edited
Loading

Pull Request for Issue #23709 .

Summary of Changes

Added new config for showing featured contacts at the top & number of contacts to display on a contact list page.

1) Config at 'Contacts' component level for showing a number of contacts & featured contacts on top:

config-at-component-level

2) Config at Contacts menu level for showing a number of contacts & featured contacts on top:

config-at-menu-level

@vaibhavsTekdi
Feature joomla#23709 feat: New configs to display featured contacts a…
79656f7 
…t the top & number of contacts to display on a contact list page.
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Jan 29, 2019
@vaibhavsTekdi vaibhavsTekdi mentioned this pull request Jan 29, 2019
Closed
@Quy Quy mentioned this pull request Jan 29, 2019
Closed
@shraddhaSankpal27
Copy link
Copy Markdown

shraddhaSankpal27 commented Feb 19, 2019

I have tested this item ✅ successfully on 547b9d1

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23710.

1 similar comment
@uthorat
Copy link
Copy Markdown

uthorat commented Feb 20, 2019

I have tested this item ✅ successfully on 547b9d1

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23710.

@amit4106udale
Copy link
Copy Markdown

amit4106udale commented Mar 13, 2019

I have tested this item ✅ successfully on fb6d778

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23710.

@ghost
Copy link
Copy Markdown

ghost commented Mar 13, 2019

@shraddhaSankpal27 can you please retest?

brianteeman
brianteeman reviewed Mar 13, 2019
View reviewed changes
administrator/components/com_contact/config.xml Outdated
name="contacts_display_num"
type="list"
label="COM_CONTACT_NUMBER_CONTACTS_LIST_LABEL"
description="COM_CONTACT_NUMBER_CONTACTS_LIST_DESC"
Copy link
Copy Markdown
Contributor

@brianteeman brianteeman Mar 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Joomla 4 we try to avoid adding a description unless it is absolutely necessary. Its not in this case (and you didnt add a string for it anyway) so you can delete this line

Copy link
Copy Markdown
Contributor Author

@vaibhavsTekdi vaibhavsTekdi Mar 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

wilsonge
wilsonge reviewed Apr 2, 2019
View reviewed changes
components/com_contact/Model/CategoryModel.php Outdated
{
$limit = $numberOfContactsToDisplay;
}
elseif ($format === 'feed')
Copy link
Copy Markdown
Contributor

@wilsonge wilsonge Apr 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think feed needs to take priority over this

Copy link
Copy Markdown
Contributor Author

@vaibhavsTekdi vaibhavsTekdi Apr 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wilsonge done...

@ghost ghost added the J4 Issue label Apr 5, 2019
@vaibhavsTekdi
Copy link
Copy Markdown
Contributor Author

vaibhavsTekdi commented Apr 11, 2019

@wilsonge Could you please check this PR & let me know so that it gets merged ASAP.

@wilsonge wilsonge merged commit 2670763 into joomla:4.0-dev Apr 11, 2019
@wilsonge wilsonge added this to the Joomla 4.0 milestone Apr 11, 2019
@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented Apr 11, 2019

Looks good to me

@vaibhavsTekdi
Copy link
Copy Markdown
Contributor Author

vaibhavsTekdi commented Apr 11, 2019

@wilsonge Thanks for the quick reply.

This was referenced Apr 5, 2021
Closed
Merged
@brianteeman brianteeman mentioned this pull request Apr 7, 2021
Merged
richard67 pushed a commit that referenced this pull request Apr 9, 2021
@brianteeman @joomdonation
[4.0] Contact Category list limits (#33050)
ae640ed 
PR for #33021

Hopefully this resolves the bug reported with #30813.
#30904 tried to fix it by removing the feature introduced with #23710 completely which was wrong

Co-authored-by: Tuan Pham Ngoc <github@joomdonation.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wilsonge wilsonge wilsonge left review comments

+1 more reviewer

@brianteeman brianteeman brianteeman left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

J4 Issue Language Change This is for Translators

Projects

None yet

Milestone

Joomla 4.0

Development

Successfully merging this pull request may close these issues.

7 participants

@vaibhavsTekdi @shraddhaSankpal27 @uthorat @amit4106udale @wilsonge @brianteeman @joomla-cms-bot