[4.0] Redundant words by brianteeman · Pull Request #30555 · joomla/joomla-cms

brianteeman · 2020-09-02T20:37:11Z

This is a repeat of #18852

Remove just from strings … it is a redundant word and is subjective.

“Just” makes me feel like an idiot. “Just” presumes I come from a specific background, studied certain courses in university, am fluent in certain technologies, and have read all the right books, articles, and resources. “Just” is a dangerous word. http://bradfrost.com/blog/post/just/

Also removes easily and simply as they are also redundant and subjective

There is also a use of "just this category" which I have changed to "only this category" for clarity

Code review

This is a repeat of joomla#18852 Remove just from strings … it is a redundant word and is subjective. > “Just” makes me feel like an idiot. “Just” presumes I come from a specific background, studied certain courses in university, am fluent in certain technologies, and have read all the right books, articles, and resources. “Just” is a dangerous word. http://bradfrost.com/blog/post/just/ Also removes easily and simply as they are also redundant and subjective

plugins/sampledata/testing/language/en-GB/en-GB.plg_sampledata_testing.ini

…_testing.ini Co-authored-by: Quy <quy@fluxbb.org>

plugins/sampledata/testing/language/en-GB/en-GB.plg_sampledata_testing.ini

infograf768 · 2020-09-03T07:15:01Z

Any reason for changing plg_sampledata_testing as it will not be shipped with packages?

zero-24 · 2020-09-03T07:24:02Z

Any reason for changing plg_sampledata_testing as it will not be shipped with packages?

Well it is shipped with dev packages so why should we not change it there too? Some language might translate it too.

infograf768 · 2020-09-03T07:29:31Z

Some language might translate it too.

Where would they ship that? The file is (correctly) not proposed in crowdin and will not be as it will not be part of releases.

zero-24 · 2020-09-03T07:38:16Z

Where would they ship that? The file is (correctly) not proposed in crowdin and will not be as it will not be part of releases.

Well I said might not that they do and the plan is that it will still be possible to do non crowdin packages ;) So why should we not fix that for the core even when translations might or might not translate it?

infograf768 · 2020-09-03T07:39:43Z

As you like. I was just pointing the facts.

brianteeman · 2020-09-03T07:41:27Z

I have no energy for pointless arguments. This is now just for com_privacy strings

richard67 · 2020-09-03T07:43:25Z

I have tested this item ✅ successfully on fa31c0f

Code review.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30555.}

infograf768 · 2020-09-03T07:58:20Z

I have tested this item ✅ successfully on fa31c0f

Code review

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30555.}

infograf768 · 2020-09-03T07:58:37Z

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30555.}

zero-24 · 2020-09-03T08:20:55Z

Merging for now

@brianteeman I have just discussed with @infograf768 and we agreed to change the strings you mention too. Do you want to do a dedicated PR yourself or should I take that strings over?

richard67 · 2020-09-03T08:23:46Z

When taking over the strings or making a new PR, please correct string "PLG_SAMPLEDATA_TESTING_SAMPLEDATA_CONTENT_ARTICLE_37_INTROTEXT". It contains a leftover "and" which should be removed, too: "It shows how you can quickly and build a personal site" should be changed to "It shows how you can quickly build a personal site".

brianteeman · 2020-09-03T09:24:22Z

Thanks for merging.

@zero-24 not interested in a PR that will lead to inevitable bikeshedding

zero-24 · 2020-09-03T09:37:14Z

Ok will do than a PR based on your commit and the comment by Richard myself.

…om_templates * '4.0-dev' of github.com:joomla/joomla-cms: (70 commits) [4.0] Child templates consistency (joomla#30387) [4.0] favicon changes to support child templates (joomla#30388) [4.0] Update Readme for Api tests (joomla#30539) [4.0] [Multilingual Status module] Adding displaying a possible error if URL Language Code is empty (joomla#30537) [4.0] Display of horizontal mod_articles_news module (joomla#30527) [4.0] Useless installation lang strings (joomla#30568) [4.0] Numbers not digits (joomla#30559) [4.0] Accessibility plugin position (joomla#30552) [4.0] fix for inherit fields (joomla#30557) [4.0] Redundant words (joomla#30555) add missing legend to fieldset (joomla#30528) [4.0] [a11y] add statement on found results (joomla#30535) [4.0] com_finder ul instead of dl for easier styling (joomla#30534) [4.0] Messages/Alerts: using icons instead of text as heading (joomla#30516) [4.0] Increase API Test Coverage (joomla#26722) [4.0] Implementing display of password requirements for frontend (joomla#30473) [4.0] FieldsHelper: Choose a first available category correctly (joomla#30268) Sort options (joomla#30531) Clear checkboxes on back button (joomla#30498) Update _icomoon.scss (joomla#30436) ...

* [4.0] Redundant words This is a repeat of joomla#18852 Remove just from strings … it is a redundant word and is subjective. > “Just” makes me feel like an idiot. “Just” presumes I come from a specific background, studied certain courses in university, am fluent in certain technologies, and have read all the right books, articles, and resources. “Just” is a dangerous word. http://bradfrost.com/blog/post/just/ Also removes easily and simply as they are also redundant and subjective * comma * Update plugins/sampledata/testing/language/en-GB/en-GB.plg_sampledata_testing.ini Co-authored-by: Quy <quy@fluxbb.org> * revert Co-authored-by: Quy <quy@fluxbb.org>

brianteeman added 2 commits September 2, 2020 21:34

comma

98f16c5

joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Sep 2, 2020

Quy reviewed Sep 2, 2020

View reviewed changes

plugins/sampledata/testing/language/en-GB/en-GB.plg_sampledata_testing.ini Outdated Show resolved Hide resolved

Update plugins/sampledata/testing/language/en-GB/en-GB.plg_sampledata…

b2b7ead

…_testing.ini Co-authored-by: Quy <quy@fluxbb.org>

richard67 reviewed Sep 3, 2020

View reviewed changes

plugins/sampledata/testing/language/en-GB/en-GB.plg_sampledata_testing.ini Outdated Show resolved Hide resolved

revert

fa31c0f

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 3, 2020

infograf768 added this to the Joomla 4.0 milestone Sep 3, 2020

zero-24 merged commit e7545f9 into joomla:4.0-dev Sep 3, 2020

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 3, 2020

brianteeman deleted the simply branch September 3, 2020 09:24

jgerman-bot mentioned this pull request Sep 3, 2020

[4.0] Redundant words joomlagerman/joomla#1204

Closed

zero-24 mentioned this pull request Sep 4, 2020

[4.0] Apply the proposed changes from @brianteeman to the testing plugin language file #30571

Merged

Uh oh!

Conversation

brianteeman commented Sep 2, 2020

Code review

Uh oh!

Uh oh!

Uh oh!

infograf768 commented Sep 3, 2020

Uh oh!

zero-24 commented Sep 3, 2020

Uh oh!

infograf768 commented Sep 3, 2020

Uh oh!

zero-24 commented Sep 3, 2020

Uh oh!

infograf768 commented Sep 3, 2020

Uh oh!

brianteeman commented Sep 3, 2020

Uh oh!

richard67 commented Sep 3, 2020

Uh oh!

infograf768 commented Sep 3, 2020

Uh oh!

infograf768 commented Sep 3, 2020

Uh oh!

zero-24 commented Sep 3, 2020

Uh oh!

richard67 commented Sep 3, 2020

Uh oh!

brianteeman commented Sep 3, 2020

Uh oh!

zero-24 commented Sep 3, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants