[4.0] Accessibility plugin position#30552
Merged
laoneo merged 1 commit intojoomla:4.0-devfrom Sep 3, 2020
Merged
Conversation
This simple PR flips the display of the plugin from the right hand side to the left hand side in LTR languages and the opposite in RTL languages This is to avoid clashing with the menu icon on mobile displays. On desktops it probably makes more sense this way as its with the menus. ### Steps to reproduce the issue Enable Plugin: System - Additional Accessibility Features mobile view scroll to bottom ### AFTER LTR ### AFTER RTL
Contributor
|
I have tested this item ✅ successfully on 2b1ce7b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30552. |
1 similar comment
|
I have tested this item ✅ successfully on 2b1ce7b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30552. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30552. |
Contributor
Author
|
Drone errors are completely unrelated and just the usual test that fails |
Member
|
Thanks! |
Contributor
Author
|
thanks |
dgrammatiko
added a commit
to dgrammatiko/joomla-cms
that referenced
this pull request
Sep 29, 2020
…om_templates * '4.0-dev' of github.com:joomla/joomla-cms: (70 commits) [4.0] Child templates consistency (joomla#30387) [4.0] favicon changes to support child templates (joomla#30388) [4.0] Update Readme for Api tests (joomla#30539) [4.0] [Multilingual Status module] Adding displaying a possible error if URL Language Code is empty (joomla#30537) [4.0] Display of horizontal mod_articles_news module (joomla#30527) [4.0] Useless installation lang strings (joomla#30568) [4.0] Numbers not digits (joomla#30559) [4.0] Accessibility plugin position (joomla#30552) [4.0] fix for inherit fields (joomla#30557) [4.0] Redundant words (joomla#30555) add missing legend to fieldset (joomla#30528) [4.0] [a11y] add statement on found results (joomla#30535) [4.0] com_finder ul instead of dl for easier styling (joomla#30534) [4.0] Messages/Alerts: using icons instead of text as heading (joomla#30516) [4.0] Increase API Test Coverage (joomla#26722) [4.0] Implementing display of password requirements for frontend (joomla#30473) [4.0] FieldsHelper: Choose a first available category correctly (joomla#30268) Sort options (joomla#30531) Clear checkboxes on back button (joomla#30498) Update _icomoon.scss (joomla#30436) ...
sakiss
pushed a commit
to sakiss/joomla-cms
that referenced
this pull request
Oct 16, 2020
This simple PR flips the display of the plugin from the right hand side to the left hand side in LTR languages and the opposite in RTL languages This is to avoid clashing with the menu icon on mobile displays. On desktops it probably makes more sense this way as its with the menus. ### Steps to reproduce the issue Enable Plugin: System - Additional Accessibility Features mobile view scroll to bottom ### AFTER LTR ### AFTER RTL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #30551
This simple PR flips the display of the plugin from the right hand side to the left hand side in LTR languages and the opposite in RTL languages
This is to avoid clashing with the menu icon on mobile displays.
On desktops it probably makes more sense this way as its with the menus.
Steps to reproduce the issue
Enable Plugin: System - Additional Accessibility Features
mobile view
scroll to bottom
BEFORE LTR
AFTER LTR
AFTER RTL