[4.0] Toggle Password Visibility#27425
Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom Jan 7, 2020
Merged
Conversation
Now that the code has been fixed with joomla#27412 I can update the strings to be more meaningful. The strings for Screen Readers are now "Show Password" and "Hide Password"
Contributor
|
I have tested this item ✅ successfully on 6220a78 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27425. |
1 similar comment
Member
|
I have tested this item ✅ successfully on 6220a78 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27425. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27425. |
Contributor
|
Thanks! |
Contributor
Author
|
w00t |
brianteeman
added a commit
to brianteeman/joomla-cms
that referenced
this pull request
Feb 4, 2020
Now that the code has been fixed with joomla#27412 I can update the strings to be more meaningful. The strings for Screen Readers are now "Show Password" and "Hide Password"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the code has been fixed with #27412 I can update the strings to be more meaningful.
The strings for Screen Readers are now "Show Password" and "Hide Password"
Testing Instructions
Make sure you are the current codebase (ie you have #27412)
Apply this PR
Update the javascript with
npm i
Inspect the password field in the admin user manager, admin login, site login
The strings for Screen Readers are now "Show Password" and "Hide Password"