[4.0] Password view toggle fixes#27412
Merged
HLeithner merged 2 commits intojoomla:4.0-devfrom Jan 6, 2020
SharkyKZ:j4/js/password-view
Merged
[4.0] Password view toggle fixes#27412HLeithner merged 2 commits intojoomla:4.0-devfrom SharkyKZ:j4/js/password-view
HLeithner merged 2 commits intojoomla:4.0-devfrom
SharkyKZ:j4/js/password-view
Conversation
Contributor
|
Thank you. |
Contributor
|
I have tested this item 🔴 unsuccessfully on c89ea1f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27412. |
Contributor
|
Almost but not quite
|
Contributor
Author
|
Test again please. |
Contributor
|
I have tested this item ✅ successfully on f1c37d7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27412. |
Contributor
|
I have tested this item ✅ successfully on f1c37d7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27412. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27412. |
Member
|
Thanks |
brianteeman
added a commit
to brianteeman/joomla-cms
that referenced
this pull request
Jan 6, 2020
Now that the code has been fixed with joomla#27412 I can update the strings to be more meaningful. The strings for Screen Readers are now "Show Password" and "Hide Password"
wilsonge
pushed a commit
that referenced
this pull request
Jan 7, 2020
Now that the code has been fixed with #27412 I can update the strings to be more meaningful. The strings for Screen Readers are now "Show Password" and "Hide Password"
brianteeman
pushed a commit
to brianteeman/joomla-cms
that referenced
this pull request
Feb 4, 2020
brianteeman
added a commit
to brianteeman/joomla-cms
that referenced
this pull request
Feb 4, 2020
Now that the code has been fixed with joomla#27412 I can update the strings to be more meaningful. The strings for Screen Readers are now "Show Password" and "Hide Password"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27401.
Summary of Changes
Makes password view toggle markup consistent.
Fixes toggler in frontend login form.
Corrects selector in JS.
Testing Instructions
Test that password view toggle works in admin login, frontend login (module) and registration forms. Check that Show/Hide text is toggled correctly (using screen reader or using browser dev tools).
Documentation Changes Required
No.