Skip to content

batch copy permission on module#24737

Merged
HLeithner merged 3 commits intojoomla:stagingfrom
alikon:patch-121
May 18, 2019
Merged

batch copy permission on module#24737
HLeithner merged 3 commits intojoomla:stagingfrom
alikon:patch-121

Conversation

@alikon
Copy link
Copy Markdown
Contributor

@alikon alikon commented Apr 27, 2019

follow up #24730 for module batch copy.

Summary of Changes

let's copy permission too

Testing Instructions

  • Create/edit a module.
  • Go to its permission tab and make a change. (e.g registered->allow creating)
  • Go to Batch and Copy it somewhere else.

Expected result

the permission are copyied too

Actual result

permission are not copied

richard67
richard67 requested changes Apr 27, 2019
View reviewed changes
@richard67
Copy link
Copy Markdown
Member

richard67 commented Apr 27, 2019

I have tested this item ✅ successfully on 8f074f3

I've tested with 2 modules which had differenc ACL modifications.
Both modules copied together in 1 batch action.
Before patch: Copied modules have ACL like in new modules.
After patch: Each of the module copies has ACL like the particular copy source module.

Drone error (javascript) seems not to be related to this PR. Code style is ok.

@HLeithner and @wilsonge Release leads please check as also with PR #24730 and PR #24736 if this is a bug fix so it goes into 3.9.next or a new feature for 4.0.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24737.

@viocassel
Copy link
Copy Markdown
Contributor

viocassel commented Apr 27, 2019

I have tested this item ✅ successfully on 8f074f3

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24737.

@ghost
Copy link
Copy Markdown

ghost commented Apr 27, 2019

Status "Ready To Commit".

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 27, 2019
@richard67 richard67 mentioned this pull request Apr 27, 2019
Closed
@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Apr 27, 2019

relaunch drone

@richard67
Copy link
Copy Markdown
Member

richard67 commented May 18, 2019

@franz-wohlkoenig Any reason why this is not merged? Has 2 good tests, has RTC. Only thing is it needs a "rebase" (i.e. merge from staging).

@infograf768
Copy link
Copy Markdown
Member

infograf768 commented May 18, 2019

Rebased. @HLeithner please decide if merging in 3.9

@HLeithner HLeithner merged commit c8d1f4f into joomla:staging May 18, 2019
@HLeithner HLeithner added this to the Joomla 3.9.7 milestone May 18, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 18, 2019
@alikon alikon deleted the patch-121 branch May 19, 2019 05:45
tecpromotion pushed a commit to tecpromotion/joomla-cms that referenced this pull request May 23, 2019
@alikon @tecpromotion
batch copy permission on module (joomla#24737)
669003c
@getimo
Copy link
Copy Markdown

getimo commented Apr 17, 2023

Any progress on that?

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24737.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richard67 richard67 richard67 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Joomla 3.9.7

Development

Successfully merging this pull request may close these issues.

7 participants

@alikon @richard67 @viocassel @infograf768 @getimo @HLeithner @joomla-cms-bot