com_categories: batch copy not copy permission#24730
com_categories: batch copy not copy permission#24730HLeithner merged 4 commits intojoomla:stagingfrom alikon:patch-81
Conversation
|
Does this not have to be done everywhere there is |
|
yes, true, just let see if this is considered a bug fix or a new feature before |
|
I have tested this item ✅ successfully on 3947e0e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24730. |
|
Imho, looks rather as a bug fix, not a new feature. |
|
@infograf768 Well, you still can use copy because being too lazy to type again other stuff like title or desciption, which may be the same for some sub-categories below different parent categories. So I am not sure if this PR has to be considered as bug fix or as a new feature. I would vote for bug fix, too, but I think release leaders should decide. => Ping @HLeithner for 3.9 and @wilsonge for 4.0. (Meanwhile I am preparing myself for testing.) |
|
@alikon [27-Apr-2019 11:40:38 Europe/Berlin] PHP Notice: Trying to get property of non-object in ~/libraries/src/UCM/UCMType.php on line 169 EDITThe Notice is also present here before this PR |
|
@infograf768 unable to reproduce the notice |
|
hmm... Maybe the Notice is specific to a multilingual site? |
|
I have tested this item ✅ successfully on 3947e0e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24730. |
|
@infograf768 I was also not able to reproduce the notice. Tested on monolingual fresh install with testing sample data. |
|
Ok, found the issue. I had in the content_types table a remaining of a 3rd party extension (Breezing forms) which had been deleted for long from the site but left a row in the table... |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24730. |
|
@franz-wohlkoenig Any reason why this is not merged? Has 2 good tests, has RTC. Only thing is it needs a "rebase" (i.e. merge from staging). |
|
Rebased. |
|
thx |
Pull Request for Issue #8600.
Summary of Changes
let's copy permission too
Testing Instructions
Expected result
the permission are copyed
Actual result
permission are not copied