Skip to content

com_categories: batch copy not copy permission#24730

Merged
HLeithner merged 4 commits intojoomla:stagingfrom
alikon:patch-81
May 18, 2019
Merged

com_categories: batch copy not copy permission#24730
HLeithner merged 4 commits intojoomla:stagingfrom
alikon:patch-81

Conversation

@alikon
Copy link
Copy Markdown
Contributor

@alikon alikon commented Apr 26, 2019

Pull Request for Issue #8600.

Summary of Changes

let's copy permission too

Testing Instructions

  • Create a category.
  • Go to its permission tab and make a change. (e.g registered->allow creating)
  • Go to Batch and Copy it somewhere else.

Expected result

the permission are copyed

Actual result

permission are not copied

@ghost
Copy link
Copy Markdown

ghost commented Apr 26, 2019

@peteruoi @AlexRed can you please test?

@brianteeman
Copy link
Copy Markdown
Contributor

Does this not have to be done everywhere there is function batchCopy

@alikon
Copy link
Copy Markdown
Contributor Author

alikon commented Apr 26, 2019

yes, true, just let see if this is considered a bug fix or a new feature before
and then we can do other's pr for article etc....

@ghost ghost changed the title [com_categories] batch copy not copy permission com_categories: batch copy not copy permission Apr 27, 2019
@infograf768
Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on 3947e0e

++


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24730.

@infograf768
Copy link
Copy Markdown
Member

Imho, looks rather as a bug fix, not a new feature.
Why copy a category instead of creating a new one if the permissions are not also copied?

@richard67
Copy link
Copy Markdown
Member

@infograf768 Well, you still can use copy because being too lazy to type again other stuff like title or desciption, which may be the same for some sub-categories below different parent categories.

So I am not sure if this PR has to be considered as bug fix or as a new feature.

I would vote for bug fix, too, but I think release leaders should decide.

=> Ping @HLeithner for 3.9 and @wilsonge for 4.0.

(Meanwhile I am preparing myself for testing.)

@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Apr 27, 2019

@alikon
we do have a Notice though:

[27-Apr-2019 11:40:38 Europe/Berlin] PHP Notice: Trying to get property of non-object in ~/libraries/src/UCM/UCMType.php on line 169

EDIT

The Notice is also present here before this PR

@alikon
Copy link
Copy Markdown
Contributor Author

alikon commented Apr 27, 2019

@infograf768 unable to reproduce the notice
btw i've made #24736 for copying items to another category

@infograf768
Copy link
Copy Markdown
Member

hmm... Maybe the Notice is specific to a multilingual site?
That test site is regularly updated here, so it may be another aspect

@richard67
Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on 3947e0e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24730.

@richard67
Copy link
Copy Markdown
Member

@infograf768 I was also not able to reproduce the notice. Tested on monolingual fresh install with testing sample data.

@infograf768
Copy link
Copy Markdown
Member

Ok, found the issue. I had in the content_types table a remaining of a 3rd party extension (Breezing forms) which had been deleted for long from the site but left a row in the table...

@infograf768
Copy link
Copy Markdown
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24730.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 27, 2019
@richard67 richard67 mentioned this pull request Apr 27, 2019
@richard67
Copy link
Copy Markdown
Member

@franz-wohlkoenig Any reason why this is not merged? Has 2 good tests, has RTC. Only thing is it needs a "rebase" (i.e. merge from staging).

@infograf768
Copy link
Copy Markdown
Member

Rebased.
@HLeithner to decide merging or not.

@HLeithner HLeithner merged commit 91d6dba into joomla:staging May 18, 2019
@HLeithner
Copy link
Copy Markdown
Member

thx

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 18, 2019
@HLeithner HLeithner added this to the Joomla 3.9.7 milestone May 18, 2019
@alikon alikon deleted the patch-81 branch May 19, 2019 05:46
tecpromotion pushed a commit to tecpromotion/joomla-cms that referenced this pull request May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants