[4.0] RFC Quickicons Joomla and Extensions updates by infograf768 · Pull Request #23095 · joomla/joomla-cms

infograf768 · 2018-11-16T10:52:35Z

Replaces and complete #23061 (for what concerns Joomla Update).

Summary of Changes

Adding Joomla Version
Change icon color to warning when an update is available as danger is used in case of error.
Place the Update Now and View Updates buttons to the bottom right of the Message, centering the rest of the message.
Adapt Atum CSS concerned to RTL, including the joomla-alert
Correct unnecessary , and : in the language strings
Correct Text::script to false by default to let single quotes in language strings to display unescaped instead of \'

Testing Instructions

To test on 4.0-dev branch

Concerning joomlaupdate:
Modify version.php line 63 to const EXTRA_VERSION = 'alpha4-dev';
Go to database and Fix database.
Then in JoomlaUpdate Options choose Custom URL and add this link (Thanks Tobias) :
https://update.joomla.org/core/nightlies/next_major_list.xml
Save Options.
Display Control Panel.

Concerning extensions update:
Install an older language pack in order to get a warning for an update.
fr-FR_joomla_lang_full_3.9.0v1.zip

in both cases, test also RTL by installing and switching to Persian language.

Test before patch, then run npm ci

Expected result

@tuum @wilsonge

brianteeman · 2018-11-16T10:55:53Z

administrator/templates/atum/scss/template-rtl.scss

+
+// Quickicon specific
+.message-alert {
+  text-align: left !important;


surely there is a way to do this without using !important

This is what is used in node_modules and vendor:

@each $breakpoint in map-keys($grid-breakpoints) { @include media-breakpoint-up($breakpoint) { $infix: breakpoint-infix($breakpoint, $grid-breakpoints); .text#{$infix}-left { text-align: left !important; } .text#{$infix}-right { text-align: right !important; } .text#{$infix}-center { text-align: center !important; } } }

and ported to /administrator/templates/atum/css/bootstrap.css once npm ci has run:

.text-left { text-align: left !important; } .text-right { text-align: right !important; } .text-center { text-align: center !important; }

administrator/language/en-GB/en-GB.plg_quickicon_joomlaupdate.ini

administrator/language/en-GB/en-GB.plg_quickicon_extensionupdate.ini

brianteeman

punctuation as commented inline

brianteeman

approve language strings

administrator/templates/atum/scss/template-rtl.scss

richard67 · 2018-11-17T10:33:39Z

I have tested this item ✅ successfully on a419403

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23095.}

infograf768 · 2018-11-18T09:44:08Z

Note: furher PR will correct RTL for the J version

infograf768 · 2018-11-18T10:16:40Z

@richard67
I need to update this now for RTL version but also for another js issue.
Please test again after I updated.

infograf768 · 2018-11-18T10:56:28Z

@richard67
OK, you can test again now.
The modifications concern the version in RTL (Test by using Persian), as well as showing the Joomlaupdate Quickicon in Green when there is no Update available.

richard67 · 2018-11-18T11:40:49Z

@infograf768 I don't see any difference in the Persian screenshots. What has changed?

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23095.}

infograf768 · 2018-11-18T11:45:10Z

formerly (see on top), the version read alpha6-dev etc.
it now displays correctly 4.0.0-alpha etc, i.e. the version is ltr in a rtl lang string

richard67 · 2018-11-18T11:46:47Z

I see now.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23095.}

richard67 · 2018-11-18T11:58:20Z

@infograf768 Now I tested and it seemed ok. But after switching back the Joomla update channel to "Default" and changing back Version.php and fixing the database, I get a javascript error from the Joomla update check, and the update check does not finish:

Reverting the PR and running "npm ci" does not fix that, so I am not sure if related to this PR or not.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23095.}

richard67 · 2018-11-18T12:13:42Z

@infograf768 I've started again with clean 4.0-dev, installed patch tester, applied your patch, run "npm ci", switched on system debugging in global settings so uncompressed js is used.
The js error is in jupdatecheck.js, row 32, column 11, which is statement "if (updateInfo.version === options.version) {", and sais "TypeError: updateInfo is undefined".
This seems to come from your last change.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23095.}

richard67 · 2018-11-18T12:17:37Z

@infograf768 It seems that the "if (updateInfoList.length === 0) {" you've removed with your last change was not there for no reason.

infograf768 · 2018-11-18T12:39:42Z

on ipad now. will look later. the issue was to get the ‘success’ class instead of only ‘pulse’. we may have to define as var and empty the ‘updateinfo.version’ first.

richard67 · 2018-11-18T13:01:17Z

@infograf768 Can you check if my PR infograf768#50 against your branch is the right thing to correct it and get what you want with the success class? Unfortunately I made a mistake in title of the commit so it contains "warning" instead of "success", which is misleading. So you better just check it and if ok do the same change yourself.

richard67 · 2018-11-18T13:30:13Z

@infograf768 I've just tested my changes from infograf768#50, applied to this PR here, and it works. Javascript error is gone, and Joomla Update is green.

infograf768 · 2018-11-18T15:48:16Z

Thanks @richard67
I mark your test Ok again.

richard67 · 2018-11-18T16:04:30Z

Yes, I've just tested again, works all well.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23095.}

C-Lodder · 2018-11-19T21:45:43Z

administrator/templates/atum/scss/template-rtl.scss

+}
+
+// Message specific
+joomla-alert .joomla-alert--close, joomla-alert .joomla-alert-button--close {


Alerts are not part of the template. please put RTL CSS in the custom element file

@C-Lodder
This is an override for RTL.
The scss for alert is in /node_modules/joomla-ui-custom-elements/src/scss/alert/alert.scss

There is no provisions done for RTL in custom-elements which means we would have to use html[dir=rtl] (which is not a problem I guess).

Also it means that until someone merges a possible pull request in https://github.com/joomla-projects/custom-elements/blob/master/dist/css/joomla-alert.css and possibly https://github.com/joomla-projects/custom-elements/blob/master/dist/css/joomla-alert.min.css, this PR would not correct by itself the RTL display issue with alerts.

EDIT: Maybe it is only in https://github.com/joomla-projects/custom-elements/blob/master/src/scss/alert/alert.scss

The other solution I see is to add these (with html[dir=rtl] ), in the atum/scss/blocks/_alert.scss and also in Cassiopea equivalent file —which means that every 3rd party template will necessarily have to do that to be rtl compatible.

Just let me know what is the way to go.
calling @wilsonge as he has the hand on merging stuff in https://github.com/joomla-projects/custom-elements

@C-Lodder
ping 😄

After discussion with @wilsonge will make PR towards https://github.com/joomla-projects/custom-elements/blob/master/src/scss/alert/alert.scss
and delete the same in template-rtl.scss>

We will have to wait the PR is merged and compile is done to see the rtl results here.

infograf768 · 2018-11-23T09:14:27Z

RTL can now be tested fully as alert has been updated.
One has to use present 4.0.0-dev branch, patch and run npm ci.

Result:

@richard67

richard67 · 2018-11-24T09:27:45Z

I have tested this item ✅ successfully on 4ed7a1b

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23095.}

infograf768 · 2018-11-24T16:13:26Z

@wilsonge
same comment as in the other PR.
RTL testers are a rare category... ;)

wilsonge · 2018-11-28T11:45:20Z

Thanks JM!

infograf768 · 2018-11-28T11:48:10Z

and @richard67 ;)

[4.0] RFC Quickicons Joomla and Extensions updates

859d287

infograf768 requested a review from brianteeman as a code owner November 16, 2018 10:52

joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Nov 16, 2018

infograf768 mentioned this pull request Nov 16, 2018

[4.0] Adding Joomla Version in Quickicon #23061

Closed

infograf768 added the J4 Issue label Nov 16, 2018

brianteeman reviewed Nov 16, 2018

View reviewed changes

administrator/language/en-GB/en-GB.plg_quickicon_joomlaupdate.ini Outdated Show resolved Hide resolved

brianteeman reviewed Nov 16, 2018

View reviewed changes

administrator/language/en-GB/en-GB.plg_quickicon_extensionupdate.ini Outdated Show resolved Hide resolved

brianteeman suggested changes Nov 16, 2018

View reviewed changes

added punctuation

e822a80

brianteeman approved these changes Nov 16, 2018

View reviewed changes

infograf768 mentioned this pull request Nov 16, 2018

[4.0] Updates are available! 1 #22978

Closed

Quy reviewed Nov 16, 2018

View reviewed changes

administrator/templates/atum/scss/template-rtl.scss Outdated Show resolved Hide resolved

2 spaces

605bfc5

infograf768 force-pushed the 4.0-quickicon-all-updates branch from 34d6646 to 605bfc5 Compare November 17, 2018 06:39

infograf768 mentioned this pull request Nov 18, 2018

[4.0] SUGGEST: Control panel icons design #23103

Closed

correcting RTL for JVersion as well as an error in the js

a330779

infograf768 force-pushed the 4.0-quickicon-all-updates branch from a419403 to a330779 Compare November 18, 2018 10:52

richard67 mentioned this pull request Nov 18, 2018

Revert last change, add success for equal version infograf768/joomla-cms#50

Merged

C-Lodder reviewed Nov 19, 2018

View reviewed changes

Taking off rtl alert from template

0b2d04f

infograf768 force-pushed the 4.0-quickicon-all-updates branch from 573f0ac to 0b2d04f Compare November 21, 2018 17:02

wilsonge and others added 3 commits November 21, 2018 23:17

Merge branch '4.0-dev' into 4.0-quickicon-all-updates

676acff

Merge branch '4.0-dev' into 4.0-quickicon-all-updates

181051b

Merge branch '4.0-dev' into 4.0-quickicon-all-updates

4ed7a1b

Merge branch '4.0-dev' into 4.0-quickicon-all-updates

029fa89

wilsonge merged commit 21fd824 into joomla:4.0-dev Nov 28, 2018

wilsonge added this to the Joomla 4.0 milestone Nov 28, 2018

infograf768 deleted the 4.0-quickicon-all-updates branch November 28, 2018 11:45

infograf768 added a commit to infograf768/joomla-cms that referenced this pull request Dec 1, 2018

[4.0] Joomla update: correcting missing code from joomla#23095

3062ce3

infograf768 mentioned this pull request Dec 1, 2018

[4.0] Joomla update: correcting missing code from #23095 #23214

Merged

wilsonge pushed a commit that referenced this pull request Dec 4, 2018

[4.0] Joomla update: correcting missing code from #23095 (#23214)

5df86bc

Uh oh!

Conversation

infograf768 commented Nov 16, 2018

Summary of Changes

Testing Instructions

Expected result

Uh oh!

brianteeman Nov 16, 2018

Choose a reason for hiding this comment

Uh oh!

infograf768 Nov 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

brianteeman left a comment

Choose a reason for hiding this comment

Uh oh!

brianteeman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

richard67 commented Nov 17, 2018

Uh oh!

infograf768 commented Nov 18, 2018

Uh oh!

infograf768 commented Nov 18, 2018

Uh oh!

infograf768 commented Nov 18, 2018

Uh oh!

richard67 commented Nov 18, 2018

Uh oh!

infograf768 commented Nov 18, 2018

Uh oh!

richard67 commented Nov 18, 2018

Uh oh!

richard67 commented Nov 18, 2018

Uh oh!

richard67 commented Nov 18, 2018

Uh oh!

richard67 commented Nov 18, 2018

Uh oh!

infograf768 commented Nov 18, 2018

Uh oh!

richard67 commented Nov 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

richard67 commented Nov 18, 2018

Uh oh!

infograf768 commented Nov 18, 2018

Uh oh!

richard67 commented Nov 18, 2018

Uh oh!

C-Lodder Nov 19, 2018

Choose a reason for hiding this comment

Uh oh!

infograf768 Nov 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

infograf768 Nov 20, 2018

Choose a reason for hiding this comment

Uh oh!

infograf768 Nov 21, 2018

Choose a reason for hiding this comment

Uh oh!

infograf768 commented Nov 23, 2018

Uh oh!

richard67 commented Nov 24, 2018

Uh oh!

infograf768 commented Nov 24, 2018

Uh oh!

wilsonge commented Nov 28, 2018

Uh oh!

infograf768 commented Nov 28, 2018

Uh oh!

Reviewers

Assignees

Labels

infograf768 Nov 16, 2018 •

edited

Loading

richard67 commented Nov 18, 2018 •

edited

Loading

infograf768 Nov 20, 2018 •

edited

Loading