Revert last change, add success for equal version#50
Merged
infograf768 merged 2 commits intoinfograf768:4.0-quickicon-all-updatesfrom Nov 18, 2018
Merged
Revert last change, add success for equal version#50infograf768 merged 2 commits intoinfograf768:4.0-quickicon-all-updatesfrom
infograf768 merged 2 commits intoinfograf768:4.0-quickicon-all-updatesfrom
Conversation
Revert last change and add warning class for equal version at the right place
Author
|
I've just tested here, it works. Javascript error gone, and color of Joomla Update is green. |
Owner
|
Thanks. It works fine. I merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fir for Joomla CMS PR joomla#23095.
Revert last change and add success class for equal version at the right place.
Sorry, title of commit is wrong, it tells "warning" and not "success", which is misleading.