Skip to content

python 2.7 fixes for numpy 1.15#3

Merged
jni merged 2 commits intojni:backport-3242from
hmaarrfk:backport-3242
Aug 15, 2018
Merged

python 2.7 fixes for numpy 1.15#3
jni merged 2 commits intojni:backport-3242from
hmaarrfk:backport-3242

Conversation

@hmaarrfk
Copy link
Copy Markdown

Fixes the two main warnings.

Also combines scikit-image#3205

Checklist

[It's fine to submit PRs which are a work in progress! But before they are merged, all PRs should provide:]

[For detailed information on these and other aspects see scikit-image contribution guidelines]

References

[If this is a bug-fix or enhancement, it closes issue # ]
[If this is a new feature, it implements the following paper: ]

For reviewers

(Don't remove the checklist below.)

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.
  • Consider backporting the PR with @meeseeksdev backport to v0.14.x

@jni
Copy link
Copy Markdown
Owner

jni commented Aug 15, 2018

Woot, LGTM, let me know if you are ready for me to merge!

@hmaarrfk
Copy link
Copy Markdown
Author

yeah it is done.

@hmaarrfk
Copy link
Copy Markdown
Author

wait wait

@hmaarrfk
Copy link
Copy Markdown
Author

novice backport first. Can you BDFL that. otherwise we will wait for ever for travis.

@hmaarrfk
Copy link
Copy Markdown
Author

@jni
Copy link
Copy Markdown
Owner

jni commented Aug 15, 2018

Why don't you roll it into this one?

@hmaarrfk
Copy link
Copy Markdown
Author

jinx

@jni jni merged commit d2f2845 into jni:backport-3242 Aug 15, 2018
jni pushed a commit that referenced this pull request May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants