Merged
Conversation
|
Hello @hmaarrfk! Thanks for submitting the PR.
|
soupault
approved these changes
Aug 5, 2018
Member
Author
|
@meeseeksdev backport to v0.14.x |
|
Awww, sorry hmaarrfk you do not seem to be allowed to do that, please ask a repository maintainer. |
9 tasks
Member
|
@meeseeksdev backport to v0.14.x |
hmaarrfk
added a commit
to hmaarrfk/scikit-image
that referenced
this pull request
Aug 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was failing anyway on OSX. Novice is deprecated and is causing the rest of the build to halt early.
I tried to XFAIL it, but apparently that isn't implemented for
pytestdectests.Checklist
[It's fine to submit PRs which are a work in progress! But before they are merged, all PRs should provide:]
./doc/examples(new features only)./benchmarks, if your changes aren't covered by anexisting benchmark
[For detailed information on these and other aspects see scikit-image contribution guidelines]
References
[If this is a bug-fix or enhancement, it closes issue # ]
[If this is a new feature, it implements the following paper: ]
For reviewers
(Don't remove the checklist below.)
later.
__init__.py.doc/release/release_dev.rst.@meeseeksdev backport to v0.14.x