Merged
Conversation
Remove the ant build for JFlex. It adds mainteance cost but provides no benefit.
lsf37
approved these changes
Oct 10, 2018
Member
lsf37
left a comment
There was a problem hiding this comment.
Ok, let's do this. Have you checked if the ant build is mentioned in the README or other docs?
Member
Author
|
I don't think there is any reference in the documentation (except the JFlexAntTask or the examples). |
Member
|
Good catch. LGTM, then. |
regisd
added a commit
to regisd/jflex
that referenced
this pull request
Oct 26, 2018
Follow-up of jflex-de#432 and jflex-de#377
Merged
regisd
added a commit
that referenced
this pull request
Oct 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the ant build for JFlex. In my opinion, it adds maintenance cost but provides no benefit.
What's more, it can mislead someone into thinking that the .jar we publish is made with ant.
Note that ant is still used on the examples ; which is valuable.