Remove openjdk7 from the build matrix#377
Merged
regisd merged 2 commits intojflex-de:masterfrom Sep 28, 2018
Merged
Conversation
- This will allow to bump the version of multiple maven plugins - The code is still compiled with `-target 1.7` defined in maven-compiler-plugin - JDK7 is largely deprecated on the market
lsf37
approved these changes
Sep 28, 2018
Member
lsf37
left a comment
There was a problem hiding this comment.
If I understand correctly, this would give us build dependency on >= 1.8, but runtime still on >= 1.7.
That'd be fine with me. Ideally we'd still test that the runtime works with 1.7, but that'll take a bit more work that we can do separately if we decide we care enough.
Member
Author
|
Yes, that's correct. The build time dep would be java 8 (which allows to use more recent version of all plugins), but the actual jflex artifacts are still java 7. |
regisd
added a commit
to regisd/jflex
that referenced
this pull request
Oct 26, 2018
Follow-up of jflex-de#432 and jflex-de#377
Merged
regisd
added a commit
that referenced
this pull request
Oct 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-target 1.7defined in maven-compiler-plugin