Fixes #12916 - Bad example in JavaDoc of InputStreamResponseListener.#12927
Merged
sbordet merged 1 commit intoMar 21, 2025
Merged
Conversation
Made InputStreamResponseListener implement AutoCloseable. Updated tests, javadocs and documentation. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
lorban
approved these changes
Mar 21, 2025
mperktold
reviewed
Mar 21, 2025
| @Override | ||
| public void close() throws IOException | ||
| { | ||
| stream.updateAndGet(input -> input == null ? InputStream.nullInputStream() : input).close(); |
There was a problem hiding this comment.
This doesn't really change anything if the stream was never created.
I expected this to release all chunks that have been received already, and probably abort an already demanded but not yet received chunk, or maybe the whole response (does that actually happen in Input.close?).
So when the InputStream hasn't been created yet, the behavior should be similar to getInputStream().close(). You could achieve this by changing this slightly to create a real Input instead of a nullInputStream, or you could try avoiding to create a stream and invoking the corresponding logic directly.
sbordet
added a commit
that referenced
this pull request
Mar 23, 2025
Fixed InputStreamResponseListener.close() to properly flip the `closed` field. Made InputStreamResponseListener.close() and InputStreamResponseListener.Input.close() call the same code. Fixed buffer leaking by releasing the network buffer upon connection close in HTTP and FCGI. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet
added a commit
that referenced
this pull request
Mar 23, 2025
Fixed InputStreamResponseListener.close() to properly flip the `closed` field. Made InputStreamResponseListener.close() and InputStreamResponseListener.Input.close() call the same code. Fixed buffer leaking by releasing the network buffer upon connection close in HTTP and FCGI. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Contributor
Author
|
See also #12931. |
Contributor
Author
|
@mperktold can you please review #12931? |
|
@sbordet looks good now! I see that you also improved releasing the buffers, that's great! 👍 |
sbordet
added a commit
that referenced
this pull request
Mar 25, 2025
* Fixed InputStreamResponseListener.close() to properly flip the `closed` field. * Made InputStreamResponseListener.close() and InputStreamResponseListener.Input.close() call the same code. * Fixed buffer leaking by releasing the network buffer upon connection close in HTTP and FCGI. * Fixed race in HTTP2Stream. A DATA frame could have been enqueued even if the stream was reset or failed, and stay there without being released. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made InputStreamResponseListener implement AutoCloseable. Updated tests, javadocs and documentation.