Addendum to #12927 for #12916.#12931
Merged
sbordet merged 12 commits intoMar 25, 2025
Merged
Conversation
Fixed InputStreamResponseListener.close() to properly flip the `closed` field. Made InputStreamResponseListener.close() and InputStreamResponseListener.Input.close() call the same code. Fixed buffer leaking by releasing the network buffer upon connection close in HTTP and FCGI. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
gregw
previously approved these changes
Mar 23, 2025
…ilures. This causes reads and writes failures to be concurrent, which makes more complicated to control the release of resources such as the network buffer used in reads. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
A call to completeWrite() may block, so it cannot block the read side as well.
…ly on atomicity of close(Throwable) to release the network buffer. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
A DATA frame could have been enqueued even if the stream was reset or failed, and stay there without being released. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
lorban
reviewed
Mar 24, 2025
| @Tag("DisableLeakTracking:client:FCGI") | ||
| @Tag("DisableLeakTracking:client:UNIX_DOMAIN") | ||
| @Tag("flaky") | ||
| public void testDownloadWithCloseBeforeContent(Transport transport) throws Exception |
Contributor
There was a problem hiding this comment.
@Tag("DisableLeakTracking:client:H3") should stay.
|
|
||
| @ParameterizedTest | ||
| @MethodSource("transports") | ||
| @Tag("DisableLeakTracking:client") |
Contributor
There was a problem hiding this comment.
This should be replaced with @Tag("DisableLeakTracking:client:H3")
|
|
||
| @ParameterizedTest | ||
| @MethodSource("transports") | ||
| @Tag("DisableLeakTracking:client") |
Contributor
There was a problem hiding this comment.
This should be replaced with @tag("DisableLeakTracking:client:H3")
| { | ||
| if (LOG.isDebugEnabled()) | ||
| LOG.debug("Error processing {} in {}", endPoint, this, x); | ||
| releaseNetworkBuffer(); |
Contributor
There was a problem hiding this comment.
This certainly deserves a comment that explains close() is going to take care of releasing the buffer but with a thread protection thanks to a CAS.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Removed `@Tag` for UNIX_DOMAIN, as the constant does not exist anymore. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
lorban
approved these changes
Mar 25, 2025
This was referenced Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closedfield.