Skip to content

Apply patch from https://github.com/cert-manager/release/pull/113#778

Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom
SgtCoDFish:k8s1.26
Dec 16, 2022
Merged

Apply patch from https://github.com/cert-manager/release/pull/113#778
jetstack-bot merged 1 commit intocert-manager:masterfrom
SgtCoDFish:k8s1.26

Conversation

@SgtCoDFish
Copy link
Copy Markdown
Member

@SgtCoDFish SgtCoDFish commented Dec 16, 2022

No description provided.

@SgtCoDFish
apply patch from cert-manager/release#113
e225191 
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/cert-manager Indicates a PR related to cert-manager approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 16, 2022
irbekrm
irbekrm approved these changes Dec 16, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@irbekrm irbekrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arguably we could have added the periodic jobs for 1.26 in a separate PR after the PRs to add 1.26 to cert-manager master and release-1.10 are merged as else these periodics will get triggered now and go red. However, I don't see a major issue with that because we do expect them to go red, so it's just the appearance of the TestGrid :)

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2022
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Dec 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irbekrm, SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit b59e715 into cert-manager:master Dec 16, 2022
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Dec 16, 2022

@SgtCoDFish: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key cert-manager-master.yaml using file config/jobs/cert-manager/cert-manager/master/cert-manager-master.yaml
  • key cert-manager-release-1.10.yaml using file config/jobs/cert-manager/cert-manager/release-1.10/cert-manager-release-1.10.yaml
Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SgtCoDFish SgtCoDFish deleted the k8s1.26 branch December 16, 2022 12:17
@SgtCoDFish
Copy link
Copy Markdown
Member Author

SgtCoDFish commented Dec 16, 2022

Arguably we could have added the periodic jobs for 1.26 in a separate PR after the PRs to add 1.26 to cert-manager master and release-1.10 are merged as else these periodics will get triggered now and go red. However, I don't see a major issue with that because we do expect them to go red, so it's just the appearance of the TestGrid :)

Good point which I'd not considered! I agree that it's not a major issue - hopefully it'll all get merged very quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@irbekrm irbekrm irbekrm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@irbekrm irbekrm

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cert-manager Indicates a PR related to cert-manager dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SgtCoDFish @jetstack-bot @irbekrm