Add tests for for k8s 1.26 on master / release-1.10#113
Merged
jetstack-bot merged 3 commits intocert-manager:masterfrom Dec 16, 2022
Merged
Add tests for for k8s 1.26 on master / release-1.10#113jetstack-bot merged 3 commits intocert-manager:masterfrom
jetstack-bot merged 3 commits intocert-manager:masterfrom
Conversation
This version has been dropped by all cloud vendors and there's little reason to test it any more since it's EOL. Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
also adds note about updating supported k8s versions later Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
SgtCoDFish
added a commit
to SgtCoDFish/cert-manager-testing
that referenced
this pull request
Dec 16, 2022
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
irbekrm
approved these changes
Dec 16, 2022
Contributor
irbekrm
left a comment
There was a problem hiding this comment.
Thanks @SgtCoDFish this all makes sense 👍🏼
/lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irbekrm, SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added a commit
to cert-manager/testing
that referenced
this pull request
Dec 16, 2022
Apply patch from cert-manager/release#113
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also removes an outdated option.
Will require a followup later to make 1.26 the default for master, after support is added in the cert-manager repo by cert-manager/cert-manager#5646 being merged.
See the TODOs for more details