Skip to content

Apply new standalone licenses test #777

Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom
SgtCoDFish:licensesgomod
Dec 6, 2022
Merged

Apply new standalone licenses test #777
jetstack-bot merged 1 commit intocert-manager:masterfrom
SgtCoDFish:licensesgomod

Conversation

@SgtCoDFish
Copy link
Copy Markdown
Member

@SgtCoDFish SgtCoDFish commented Dec 6, 2022

Should be merged after cert-manager/release#111 and before cert-manager/cert-manager#5618

@SgtCoDFish
apply cert-manager/release#111
8dbd682 
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/cert-manager Indicates a PR related to cert-manager approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 6, 2022
wallrj
wallrj approved these changes Dec 6, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold until the cmrel changes get merged.

@jetstack-bot jetstack-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2022
@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2022
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Dec 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SgtCoDFish
Copy link
Copy Markdown
Member Author

SgtCoDFish commented Dec 6, 2022

/unhold

cmrel changes are now merged!

@jetstack-bot jetstack-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2022
@jetstack-bot jetstack-bot merged commit ac2e41e into cert-manager:master Dec 6, 2022
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Dec 6, 2022

@SgtCoDFish: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key cert-manager-master.yaml using file config/jobs/cert-manager/cert-manager/master/cert-manager-master.yaml
  • key cert-manager-release-1.10.yaml using file config/jobs/cert-manager/cert-manager/release-1.10/cert-manager-release-1.10.yaml
  • key cert-manager-release-1.9.yaml using file config/jobs/cert-manager/cert-manager/release-1.9/cert-manager-release-1.9.yaml
Details

In response to this:

Should be merged after cert-manager/release#111 and before cert-manager/cert-manager#5618

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SgtCoDFish SgtCoDFish deleted the licensesgomod branch December 6, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wallrj wallrj wallrj approved these changes

Assignees

@wallrj wallrj

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cert-manager Indicates a PR related to cert-manager dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SgtCoDFish @jetstack-bot @wallrj