Remove verify-licenses from ci-presubmit#5618
Remove verify-licenses from ci-presubmit#5618jetstack-bot merged 1 commit intocert-manager:masterfrom
Conversation
see cert-manager/release#111 Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
|
/cherry-pick release-1.10 |
|
@SgtCoDFish: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-1.9 |
|
@SgtCoDFish: once the present PR merges, I will cherry-pick it on top of release-1.9 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
wallrj
left a comment
There was a problem hiding this comment.
/lgtm
/hold until the new prow config gets merged.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SgtCoDFish, wallrj The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold Prow config has now merged! |
|
/test pull-cert-manager-master-e2e-v1-25 |
|
@SgtCoDFish: new pull request created: #5621 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@SgtCoDFish: new pull request created: #5622 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Pull Request Motivation
Since verify-licenses relies on third party servers it can flake for reasons unrelated to changes in a PR. cmrel#111 adds the ability for tests to be triggered only when a named file changes; this will remove the license check from our default "make test" in favour of the version which will be invoked only when go.mod is updated.
Kind
/kind flake
Release Note