Skip to content

Explicitly call vendor-go in legacy tests#713

Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom
SgtCoDFish:vendah
Jun 30, 2022
Merged

Explicitly call vendor-go in legacy tests#713
jetstack-bot merged 1 commit intocert-manager:masterfrom
SgtCoDFish:vendah

Conversation

@SgtCoDFish
Copy link
Copy Markdown
Member

@SgtCoDFish SgtCoDFish commented Jun 30, 2022 •
edited
Loading

See this gotcha warning: https://github.com/cert-manager/cert-manager/blob/066fcbbbfa0e9840632a5dc3a5c36f6261c53405/make/tools.mk#L423-L426

These targets will change again in #712 which can be merged after cert-manager/cert-manager#5252 - but first we need this as a temporary workaround to enable the changes in cert-manager#5252 to work.

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/cert-manager Indicates a PR related to cert-manager approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 30, 2022
@SgtCoDFish SgtCoDFish mentioned this pull request Jun 30, 2022
Merged
irbekrm
irbekrm approved these changes Jun 30, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@irbekrm irbekrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2022
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Jun 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irbekrm, SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit 8164451 into cert-manager:master Jun 30, 2022
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Jun 30, 2022

@SgtCoDFish: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key cert-manager-presubmits.yaml using file config/jobs/cert-manager/cert-manager/cert-manager-presubmits.yaml
Details

In response to this:

See this gotcha warning: https://github.com/cert-manager/cert-manager/blob/066fcbbbfa0e9840632a5dc3a5c36f6261c53405/make/tools.mk#L423-L426

These targets will change again in #712 which can be merged after cert-manager/cert-manager#5252 - but first we need this as a temporary workaround to enable the changes in cert-manager#5252 to work.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@irbekrm irbekrm irbekrm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@irbekrm irbekrm

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cert-manager Indicates a PR related to cert-manager dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SgtCoDFish @jetstack-bot @irbekrm