Update upgrade test to reference new target#712
Update upgrade test to reference new target#712jetstack-bot merged 2 commits intocert-manager:masterfrom
Conversation
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
|
Thank you very much for working on this @SgtCoDFish ! Should we make the same change in the periodic? Apart from that happy to lgtm |
|
Good suggestion, thanks @irbekrm - not sure how I missed that. I've added a second commit which does that and also which reduces the resource requirements which seemed high. Does that look reasonable? 😁 |
|
Thanks @SgtCoDFish ! For the resource requirements, I would slightly prefer if we re-evaluated what proportion of node resources each test type needs + whether we could, for example benefit from a different node size (as there probably have been some changes in that now that we use make) + monitor for possible flakes in one single PR so that all the reasoning etc is in one place. Adding a hold if you agree else happy for it to go in as is /hold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irbekrm, SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
|
@irbekrm I've reverted the resource changes - I agree that it's probably better to attack them all in one go, yeah. |
|
Thanks @SgtCoDFish and thanks for working on this! /hold cancel |
|
@SgtCoDFish: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This should remove the last traces of bazel in our presubmits!