Skip to content

Update upgrade test to reference new target#712

Merged
jetstack-bot merged 2 commits intocert-manager:masterfrom
SgtCoDFish:upgrade
Jul 4, 2022
Merged

Update upgrade test to reference new target#712
jetstack-bot merged 2 commits intocert-manager:masterfrom
SgtCoDFish:upgrade

Conversation

@SgtCoDFish
Copy link
Copy Markdown
Member

@SgtCoDFish SgtCoDFish commented Jun 30, 2022

This should remove the last traces of bazel in our presubmits!

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/cert-manager Indicates a PR related to cert-manager approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 30, 2022
@SgtCoDFish SgtCoDFish marked this pull request as draft June 30, 2022 15:45
@jetstack-bot jetstack-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 30, 2022
@jetstack-bot jetstack-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 30, 2022
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
@SgtCoDFish SgtCoDFish marked this pull request as ready for review July 4, 2022 08:34
@jetstack-bot jetstack-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 4, 2022
@irbekrm
Copy link
Copy Markdown
Contributor

irbekrm commented Jul 4, 2022

Thank you very much for working on this @SgtCoDFish !

Should we make the same change in the periodic? Apart from that happy to lgtm

@jetstack-bot jetstack-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 4, 2022
@SgtCoDFish
Copy link
Copy Markdown
Member Author

Good suggestion, thanks @irbekrm - not sure how I missed that.

I've added a second commit which does that and also which reduces the resource requirements which seemed high. Does that look reasonable? 😁

@irbekrm
Copy link
Copy Markdown
Contributor

irbekrm commented Jul 4, 2022

Thanks @SgtCoDFish !

For the resource requirements, I would slightly prefer if we re-evaluated what proportion of node resources each test type needs + whether we could, for example benefit from a different node size (as there probably have been some changes in that now that we use make) + monitor for possible flakes in one single PR so that all the reasoning etc is in one place.
At the moment the resource requiremement for each job that spins up kind cluster is ~50% of a node so that no more than 2 such jobs get allocated to that node.

Adding a hold if you agree else happy for it to go in as is

/hold
/lgtm
/approve

@jetstack-bot jetstack-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 4, 2022
@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2022
@jetstack-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irbekrm, SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
@jetstack-bot jetstack-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 4, 2022
@SgtCoDFish
Copy link
Copy Markdown
Member Author

@irbekrm I've reverted the resource changes - I agree that it's probably better to attack them all in one go, yeah.

@irbekrm
Copy link
Copy Markdown
Contributor

irbekrm commented Jul 4, 2022

Thanks @SgtCoDFish and thanks for working on this!

/hold cancel
/lgtm

@jetstack-bot jetstack-bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 4, 2022
@jetstack-bot jetstack-bot merged commit bad42a6 into cert-manager:master Jul 4, 2022
@jetstack-bot
Copy link
Copy Markdown
Contributor

@SgtCoDFish: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key cert-manager-periodics.yaml using file config/jobs/cert-manager/cert-manager/cert-manager-periodics.yaml
  • key cert-manager-presubmits.yaml using file config/jobs/cert-manager/cert-manager/cert-manager-presubmits.yaml
Details

In response to this:

This should remove the last traces of bazel in our presubmits!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SgtCoDFish SgtCoDFish deleted the upgrade branch July 4, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cert-manager Indicates a PR related to cert-manager dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants