Add option to remove CD-ROM drives#238
Add option to remove CD-ROM drives#238eriweb wants to merge 2 commits intojetbrains-infra:masterfrom eriweb:master
Conversation
PR #173 changed the default behavior of removing CD-ROM drives. This PR adds an option called `remove_cdrom` (default false) that when enabled removed any CD-ROM devices
|
Hi terbolous,
I use latest builder provided by jetbrains |
|
Not sure if jetbrains has a service that allows you to download pull
requests or not. If not you’ll have to compile yourself.
Currently it removes all cdroms, i am not sure how to specify a single one
in a convenient way
fre. 3. mai 2019 kl. 12:33 skrev danonh <notifications@github.com>:
… Hi terbolous,
This option does not work for me, I get
Errors validating build 'rails'. 1 error(s) occurred:
- unknown configuration key: "remove_cdrom"
I use latest builder provided by jetbrains
If this works for you can you tell if "remove_cdrom" removes specific
drive or all cdrom drives configured within VM? I need an option that
removes only specific cd-rom where vmtools has been mounted.
Thanks,
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#238 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABPFILQX7AT33LADSV5OHALPTQIIXANCNFSM4HJKHHAQ>
.
|
|
Working well for me, thanks. Please, can this be merged? |
|
Hello, please can you merge this one ? We are forced to use manual steps to remove the CD.... |
|
Yes, please get this merged. It would be super handy for us! |
|
@VladRassokhin Can this be merged, or is it waiting for something? |
@rhockenbury i think this change will need to be re-submitted against the packer main repo since the plugin itself has been migrated over there. maybe? |
|
@terbolous Did you ever look at submitting this change to the main packer since this plugin is now a part of the packer project? It is unreleased at this point but this change would be nice to have. |
|
@terbolous I have pulled down the packer source and have a branch with your change added. I am testing it now. |
|
@daxgames No sorry, I didn't notice the plugin going upstream. I have no issues with you handling the PR there |
|
This has been merged into the Packer main repo and can be closed if its not going to be merged here. vsphere iso remove cdroms #8690 |
PR #173 changed the default behavior of removing CD-ROM drives and ejects them instead.
This PR adds an option called
remove_cdrom(default false) thatwhen enabled removed any CD-ROM devices from the VM/template.
This should fix #214