All committers have signed the CLA.

Hi There! This LGTM 👍
Just a little thing it's missing from the original PR and I think it's important. Can you add the new field to the documentation?
Also, I see the CI is failing because it's missing some generated code and format.
You can run go generate ./builder/vsphere/... to generate code and make fmt to format everything.

Docs and format done. I think I added the docs in the right place.

@sylviamoss Are there prerelease binaries somewhere that I am just missing or do I need to build it myself to use the pre-releases?

Edit: I thought they would be here but not.

There's one pipeline for storing artifacts (is one of the checks below). Here you can find the ones for this PR: https://circleci.com/gh/hashicorp/packer/32337#artifacts/containers/0
Is this what you wanted?

@sylviamoss Sorry for the delayed response, in the middle of moving cross country. I will look at the changes requested but I have a question.

vsphere-iso builder seems to work perfectly but vsphere-clone throws: Failed to initialize build 'vsphere-clone': error initializing builder 'vsphere-clone': Incompatible API version with plugin. Plugin version: 4, Ours: 5

Admittedly I am not super familiar with the Packer code so not sure were to look for this. I would think if one builder worked so would the other worked the other would also.

Can you try running your vsphere-clone test with our nightly version? here the binaries: https://github.com/hashicorp/packer/releases/tag/nightly
So we can check if this is not related to your changes (which I think is not 🤔 )

Trying now. Really slowly. Working from car via cellular wifi hotspot download is taking forever!

@sylviamoss same issue using the nightly and vsphere-clone

Failed to initialize build 'vsphere-clone': error initializing builder 'vsphere-clone': Incompatible API version with plugin. Plugin version: 4, Ours: 5

I suspect you still have the vsphere builder installed in your .plugin.d folder, so Packer is using it instead of the built-in one in the newer release. Delete the old one from your folder, and that should fix this API error.

@SwampDragons there was a file in $GOPATH/bin called packer-builder-vsphere-clone.working. I am surprised it picked it up given its named wrong. Deleting it fixed it.

oh good catch. Must be a weak regex. I'll check the code and see if we can tweak it to ignore extensions.

@daxgames I've opened #8735 to fix the overly-forgiving provisioner loading

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.