Temporarily disable class Array/%TypedArray%.prototype.{slice, map, concat, filter, splice} related tests#2588
Merged
LaszloLango merged 1 commit intojerryscript-project:masterfrom Nov 9, 2018
Conversation
Member
Author
zherczeg
reviewed
Nov 8, 2018
LaszloLango
reviewed
Nov 8, 2018
LaszloLango
requested changes
Nov 8, 2018
Contributor
LaszloLango
left a comment
There was a problem hiding this comment.
It looks like CONFIG_DISABLE_ES2015_SYMBOL is introduced by this patch. Please add it to the related README.md and config.h.
| ecma_object_t *object_p) /**< The object from whom the new array object | ||
| * is being created */ | ||
| { | ||
| #ifdef CONFIG_DISABLE_ES2015_SYMBOL |
Contributor
There was a problem hiding this comment.
#ifndef CONFIG_DISABLE_ES2015_SYMBOL
Member
Author
There was a problem hiding this comment.
Well, I realized that introducing this new macro without the Symbol is misleading. So I removed the related code paths, because it is not a a big removal. This is still not the best way but much better approach than using tricky macros for disabling code sections.
…oncat, filter, splice} related tests This patch temporarily fixes jerryscript-project#2587. The reason of disabling these tests is that the current implementation slightly differs from the related part of the standard (ECMA-262 v6, 9.4.2.3.6.d.1). This part requires the hidden Symbol.@@species property, hence this functionality has not been implemented yet in the project. Also add the related test case to prevent further errors. JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu
LaszloLango
approved these changes
Nov 9, 2018
Contributor
LaszloLango
left a comment
There was a problem hiding this comment.
LGTM, please raise a GitHub issue for the symbol implementation.
rerobika
added a commit
to rerobika/jerryscript
that referenced
this pull request
Nov 13, 2018
…r, splice} related tests (jerryscript-project#2588) This patch fixes jerryscript-project#2587. The reason of disabling these tests is that the current implementation slightly differs from the related part of the standard (ECMA-262 v6, 9.4.2.3.6.d.1). This part requires the hidden Symbol.@@species property, hence this functionality has not been implemented yet in the project. Also add the related test case to prevent further errors. JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu
yorkie
pushed a commit
to yodaos-project/ShadowNode
that referenced
this pull request
Nov 30, 2018
Refs: jerryscript-project/jerryscript#2431 Refs: jerryscript-project/jerryscript#2496 Refs: jerryscript-project/jerryscript#2485 Refs: jerryscript-project/jerryscript#2530 Refs: jerryscript-project/jerryscript#2547 Refs: jerryscript-project/jerryscript#2436 Refs: jerryscript-project/jerryscript#2467 Refs: jerryscript-project/jerryscript#2481 Refs: jerryscript-project/jerryscript#2408 Refs: jerryscript-project/jerryscript#2430 Refs: jerryscript-project/jerryscript#2439 Refs: jerryscript-project/jerryscript#2588
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch temporarily fixes #2587.
The reason of disabling these tests is that the current implementation slightly differs from the related part of the standard (ECMA-262 v6, 9.4.2.3.6.d.1).
This part requires the hidden Symbol.@@species property, hence this functionality has not been implemented yet in the project.
Also add the related test case to prevent further errors.
JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu