Fix the tumblr importer to import posts with multiple photos#114
Closed
Fix the tumblr importer to import posts with multiple photos#114
Conversation
Member
Author
|
Just spent 45 minutes trying to fix up the tests, to no avail. :( |
dhutchison
added a commit
to dhutchison/jekyll-import
that referenced
this pull request
Jun 1, 2014
|
(I might be missing something, first time contributing) I have merged the relevant parts of the original fix into my fork of the latest code and it appears to be working. Locally the test suite runs without issue, and (why I started looking at this) a live example now imports the images as expected. Is there anything else I would normally be expected to check? |
Member
|
@parkr to fix the specs just replace JekyllImport with Importers in line 68 and 73 in test/test_tumblr_importer.rb. Also, and not related, the indentation in that file is messed up |
Member
Author
|
Superceded by #145. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completed by @underhilllabs in #53 but it's to an out-dated master setup (file was moved).
Closes #53.