Fix the tumblr importer to import posts with multiple photos.#53
Closed
underhilllabs wants to merge 6 commits intojekyll:masterfrom
underhilllabs:master
Closed
Fix the tumblr importer to import posts with multiple photos.#53underhilllabs wants to merge 6 commits intojekyll:masterfrom underhilllabs:master
underhilllabs wants to merge 6 commits intojekyll:masterfrom
underhilllabs:master
Conversation
Adds tests for photo blog entry with one photo, as well as a test for a post with multiple photos.
Member
|
We have some other fixes that just need to be merged which may conflict with this. I'll take a closer look later. |
|
any update on this? seems like a rather important missing feature. @underhilllabs submitted the fix for it, let's get this in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability to import posts with multiple photos in a tumblr post. I added some tests for testing photo posts with a single photo and with multiple photos. I also added a new mocked JSON payload with photo posts.