test: use hash explicitly for Struct initializer for ruby 3.2#9237
Merged
jekyllbot merged 1 commit intojekyll:masterfrom Dec 29, 2022
Merged
test: use hash explicitly for Struct initializer for ruby 3.2#9237jekyllbot merged 1 commit intojekyll:masterfrom
jekyllbot merged 1 commit intojekyll:masterfrom
Conversation
ruby 3.2 changes Struct.new behavior so that keyword_init option is enabled by default. This means that keyword argument passed to the initializer of Struct is now treated differently with ruby3.2. To avoid behavior change in jekyll test code, use hash explicitly. Fixes jekyll#9236 .
Member
|
Thanks @mtasaka |
jekyllbot
added a commit
that referenced
this pull request
Dec 29, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Dec 29, 2022
Mamoru TASAKA: test: use hash explicitly for Struct initializer for ruby 3.2 (#9237) Merge pull request 9237
Contributor
Author
|
Thank you for very quick merge! |
oturpe
pushed a commit
to oturpe/jekyll
that referenced
this pull request
Jan 30, 2023
…#9237) Merge pull request 9237
mattr-
added a commit
that referenced
this pull request
Dec 27, 2023
Backport #9237 to 4.3-stable "test: use hash explicitly for Struct initializer for ruby 3.2"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ruby 3.2 changes Struct.new behavior so that keyword_init option is enabled by default. This means that keyword argument passed to the initializer of Struct is now treated differently with ruby3.2.
To avoid behavior change in jekyll test code, use hash explicitly.
Fixes #9236 .
Summary
Context