Skip to content

Backport #9237 to 4.3-stable "test: use hash explicitly for Struct initializer for ruby 3.2"#9285

Merged
mattr- merged 1 commit intojekyll:4.3-stablefrom
oturpe:ruby-3.2-fix-for-4.3.-stable
Dec 27, 2023
Merged

Backport #9237 to 4.3-stable "test: use hash explicitly for Struct initializer for ruby 3.2"#9285
mattr- merged 1 commit intojekyll:4.3-stablefrom
oturpe:ruby-3.2-fix-for-4.3.-stable

Conversation

@oturpe
Copy link
Copy Markdown
Contributor

@oturpe oturpe commented Jan 30, 2023

This is a 🐛 bug fix.

Summary

Merge request #9237 fixed running tests with Ruby 3.2.
In Fedora, we already use version of Ruby, and want to include the latest Jekyll 4.3.2.
Because of this, I ask to backport #9237 to 4.3-stable.

This project seems to use extensive automation to manage pull requests.
If you prefer, you can close this pull request and backport the merge request using your preferred method.

Context

No issue, but I can add one if you prefer to have one for the archives.
The title would be tests from 4.3-stable fail with Ruby 3.2.

@ashmaroli
Copy link
Copy Markdown
Member

Hello @oturpe,
We do not bundle the test/ directory in jekyll gem. So to me, this backport seems redundant as of now.
Is there any explicit need for this commit for vendoring Jekyll on Fedora?

@oturpe
Copy link
Copy Markdown
Contributor Author

oturpe commented Jan 30, 2023

The reason I ask for this is this:
In Fedora, we always try to run the project's test cases during package build.
This ensures that the package works correctly using Fedora's dependency versions, compiler flags, patched and so on.
For Jekyll, and many other Ruby gems, we do the following:
First, we download the official gem for the runtime parts,
then add the test cases from the corresponding Git tag.
(See here if you are interested in the details.)

For this approach to work, we either carry a downstream patch for Ruby 3.2,
or the tests need to be updated in the stable branch as proposed here.
We already have the downstream patch in place,
so it is not a big issue if you do not want to maintain the tests in stable branches.

@ashmaroli
Copy link
Copy Markdown
Member

Thanks for the insight.
Given the fact that since we don't bundle the tests/ in the gem, I won't be merging this pull request now because even if I were to cut a v4.3.3, the gem will be identical to v4.3.2.
But I won't outright close this either just in case we need to ship a critical bugfix as v4.3.3 .

@ashmaroli ashmaroli added the in-limbo Defer action to uncertain future label Jan 30, 2023
Copy link
Copy Markdown
Member

@mattr- mattr- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm cutting a 4.3.3 release, so I'll include this PR in that release as well.

@mattr- mattr- merged commit fb364ba into jekyll:4.3-stable Dec 27, 2023
@jekyll jekyll locked and limited conversation to collaborators Dec 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

frozen-due-to-age in-limbo Defer action to uncertain future

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants