Run vendor-mimes to update mime.types#8940
Merged
Conversation
ashmaroli
reviewed
Jan 19, 2022
Comment on lines
-372
to
+376
| application/vnd.ms-project mpp mpt | ||
| application/vnd.ms-project mpt |
Member
There was a problem hiding this comment.
.mpp is being removed from the list.
Are we fine with this change in a minor version bump?
Member
Author
There was a problem hiding this comment.
I'm personally fine with it! We can always add it back in – I'd rather not over-optimize for backwards compatibility in this file for uncommon file types like .mpp (Microsoft Project file?).
ashmaroli
approved these changes
Jan 20, 2022
mattr-
approved these changes
Jan 21, 2022
Member
Author
|
@jekyllbot: merge +minor |
jekyllbot
added a commit
that referenced
this pull request
Jan 21, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Jan 21, 2022
Parker Moore: Run vendor-mimes to update mime.types (#8940) Merge pull request 8940
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a 🙋 feature or enhancement.
Summary
We use (or have used in the past)
script/vendor-mimesto vendor the MIME types we use forJekyll serve. We pull down thedb.jsonfile fromjshttp/mime-dband write out a comprehensivemime.typesfile.I updated it to use
URI.open(which no longer monkey-patchesKernel#open), and then decided it'd be nice to sort the extnames.Context
#8938 and #8936 since I was thinking about trying to generate a Hash for charset-able types from db.json but couldn't get the script to run.